Your message dated Wed, 28 Jun 2023 10:51:42 +0000
with message-id <[email protected]>
and subject line Bug#1038890: fixed in pyparted 3.12.0-5
has caused the Debian Bug report #1038890,
regarding pyparted: Testsuite fails against parted 3.6
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1038890: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1038890
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: pyparted
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu mantic ubuntu-patch

Dear Maintainer,

Running the pyparted test-suite against parted 3.6 leads to the
following exception:

  399s ======================================================================
  399s FAIL: runTest (tests.test__ped_disktype.DiskTypeStrTestCase.runTest)
  399s ----------------------------------------------------------------------
  399s Traceback (most recent call last):
  399s File 
"/tmp/autopkgtest.kQxzZO/build.bFs/src/tests/test__ped_disktype.py", line 78, 
in runTest
  399s self.assertEqual(str(self.disktype['msdos']), '_ped.DiskType instance 
--\n name: msdos features: 1')
  399s AssertionError: '_ped.DiskType instance --\n name: msdos features: 5' != 
'_ped.DiskType instance --\n name: msdos features: 1'
  399s _ped.DiskType instance --
  399s - name: msdos features: 5? ^
  399s + name: msdos features: 1? ^

The failure is visible in the following autopkgtest report.

https://ci.debian.net/data/autopkgtest/unstable/amd64/p/pyparted/34699773/log.gz

A patch exists upstream: https://github.com/dcantrell/pyparted/pull/100

In Ubuntu, the attached patch was applied to achieve the following:

  * Apply upstream patch to fix test-suite against parted 3.6 (LP: #2024678)

Thanks for considering the patch.


-- System Information:
Debian Release: bookworm/sid
  APT prefers lunar-updates
  APT policy: (500, 'lunar-updates'), (500, 'lunar-security'), (500, 'lunar'), 
(100, 'lunar-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.1.0-16-generic (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru 
pyparted-3.12.0/debian/patches/0001-tests-Remove-feature-values-from-DiskTypeStrTestCase.patch
 
pyparted-3.12.0/debian/patches/0001-tests-Remove-feature-values-from-DiskTypeStrTestCase.patch
--- 
pyparted-3.12.0/debian/patches/0001-tests-Remove-feature-values-from-DiskTypeStrTestCase.patch
      1970-01-01 01:00:00.000000000 +0100
+++ 
pyparted-3.12.0/debian/patches/0001-tests-Remove-feature-values-from-DiskTypeStrTestCase.patch
      2023-06-22 18:08:47.000000000 +0200
@@ -0,0 +1,43 @@
+Description: tests: Remove feature values from DiskTypeStrTestCase
+ These inevitably cause pyparted to fail when built against a new version
+ of parted. They don't provide any additional validation, other tests
+ already check for the expected features.
+Author: "Brian C. Lane" <[email protected]>
+Origin: upstream, https://github.com/dcantrell/pyparted/pull/100
+Bug-Ubuntu: https://launchpad.net/bugs/2024678
+Last-Update: 2023-06-22
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+Index: pyparted-3.12.0/tests/test__ped_disktype.py
+===================================================================
+--- pyparted-3.12.0.orig/tests/test__ped_disktype.py   2023-06-22 
18:02:36.965289725 +0200
++++ pyparted-3.12.0/tests/test__ped_disktype.py        2023-06-22 
18:05:14.716398913 +0200
+@@ -75,13 +75,18 @@
+ 
+ class DiskTypeStrTestCase(RequiresDiskTypes):
+     def runTest(self):
+-        self.assertEqual(str(self.disktype['msdos']), '_ped.DiskType instance 
--\n  name: msdos  features: 1')
+-        self.assertEqual(str(self.disktype['aix']), '_ped.DiskType instance 
--\n  name: aix  features: 0')
+-        self.assertEqual(str(self.disktype['sun']), '_ped.DiskType instance 
--\n  name: sun  features: 0')
+-        self.assertEqual(str(self.disktype['amiga']), '_ped.DiskType instance 
--\n  name: amiga  features: 2')
+-        self.assertEqual(str(self.disktype['gpt']), '_ped.DiskType instance 
--\n  name: gpt  features: 2')
+-        self.assertEqual(str(self.disktype['mac']), '_ped.DiskType instance 
--\n  name: mac  features: 2')
+-        self.assertEqual(str(self.disktype['bsd']), '_ped.DiskType instance 
--\n  name: bsd  features: 0')
+-        self.assertEqual(str(self.disktype['pc98']), '_ped.DiskType instance 
--\n  name: pc98  features: 2')
+-        self.assertEqual(str(self.disktype['loop']), '_ped.DiskType instance 
--\n  name: loop  features: 0')
+-        self.assertEqual(str(self.disktype['dvh']), '_ped.DiskType instance 
--\n  name: dvh  features: 3')
++        types = {
++            "msdos": '_ped.DiskType instance --\n  name: msdos  features:',
++            'aix':   '_ped.DiskType instance --\n  name: aix  features: ',
++            'sun':   '_ped.DiskType instance --\n  name: sun  features: ',
++            'amiga': '_ped.DiskType instance --\n  name: amiga  features: ',
++            'gpt':   '_ped.DiskType instance --\n  name: gpt  features: ',
++            'mac':   '_ped.DiskType instance --\n  name: mac  features: ',
++            'bsd':   '_ped.DiskType instance --\n  name: bsd  features: ',
++            'pc98':  '_ped.DiskType instance --\n  name: pc98  features: ',
++            'loop':  '_ped.DiskType instance --\n  name: loop  features: ',
++            'dvh':   '_ped.DiskType instance --\n  name: dvh  features: ',
++        }
++
++        for t, expected in types.items():
++            self.assertIn(expected, str(self.disktype[t]))
diff -Nru pyparted-3.12.0/debian/patches/series 
pyparted-3.12.0/debian/patches/series
--- pyparted-3.12.0/debian/patches/series       2023-03-03 19:56:44.000000000 
+0100
+++ pyparted-3.12.0/debian/patches/series       2023-06-22 18:02:15.000000000 
+0200
@@ -1,2 +1,3 @@
 skip_0gt0.patch
 skip_for_deb_ci.patch
+0001-tests-Remove-feature-values-from-DiskTypeStrTestCase.patch

--- End Message ---
--- Begin Message ---
Source: pyparted
Source-Version: 3.12.0-5
Done: Bastian Germann <[email protected]>

We believe that the bug you reported is fixed in the latest version of
pyparted, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bastian Germann <[email protected]> (supplier of updated pyparted package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 28 Jun 2023 12:12:20 +0200
Source: pyparted
Architecture: source
Version: 3.12.0-5
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Team <[email protected]>
Changed-By: Bastian Germann <[email protected]>
Closes: 1038890
Changes:
 pyparted (3.12.0-5) unstable; urgency=medium
 .
   * Build with parted 3.6 (Closes: #1038890)
Checksums-Sha1:
 d0485a88cb74024ee9534c2ae79aa609f979e978 2254 pyparted_3.12.0-5.dsc
 c52dfa02064a67d5a09b5fbe4d85f9bdea104db9 100725 pyparted_3.12.0.orig.tar.gz
 185e60a45cc8940d38260809762917db3a4054f8 833 pyparted_3.12.0.orig.tar.gz.asc
 0ddaac555464faa3b12c071dbf926056515cd9ed 13296 pyparted_3.12.0-5.debian.tar.xz
 a6fd7ae5972ead1c25145727ddab110741cfcac4 7130 
pyparted_3.12.0-5_source.buildinfo
Checksums-Sha256:
 744faf9053ea9919fe19cba1a8a0ae1014172a395bf2ecd845078828340f56d8 2254 
pyparted_3.12.0-5.dsc
 da985e116beb733371feb605b174db9eec8bd0eedffc8f739f8e603f51b521e7 100725 
pyparted_3.12.0.orig.tar.gz
 b8fccb08e3499bcd7aa469792ed35e7ce208eab3913a87e29921ac72959ee84b 833 
pyparted_3.12.0.orig.tar.gz.asc
 74310414b99ff56fc1bfaef69b5bfb7c9d9f7dd905d6674c6061cbe7bfecdf91 13296 
pyparted_3.12.0-5.debian.tar.xz
 c017cc3ca5e0d4295cd28454ec0d1aed5e4f2b034d53af9d163ad45c91039a8b 7130 
pyparted_3.12.0-5_source.buildinfo
Files:
 10322976ffe0a49fc7cab92220ae2312 2254 python optional pyparted_3.12.0-5.dsc
 97df779564210100ea3e4eda0d33f7b9 100725 python optional 
pyparted_3.12.0.orig.tar.gz
 fcfbec21e43d41e06ce5781d74fb544d 833 python optional 
pyparted_3.12.0.orig.tar.gz.asc
 b11909b889c9e24022e58989b7c7ac9e 13296 python optional 
pyparted_3.12.0-5.debian.tar.xz
 5d77265edfacd66fcf319eb969fdff4a 7130 python optional 
pyparted_3.12.0-5_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQHEBAEBCgAuFiEEQGIgyLhVKAI3jM5BH1x6i0VWQxQFAmScDSEQHGJhZ2VAZGVi
aWFuLm9yZwAKCRAfXHqLRVZDFEOzDADrGKyZC7upPquTL5iF8ICKrswRQw+k8AZj
NZm5yo0B746byUqR98U7/2uDTAzbFGazXwr+ieQE0f9yLFKhZIOEI96Fi/TLPwDZ
G/rdRyDCwASyNeONkipVq3kew7FIx02R1sBi8BxE7z8357nXqAKk+4G+/TSNZ5BW
m5ZnMsz+uDZ0S2BFVe7RM9Zj7WgsZgSi1tlHSKsgx52OQZTz6cm3loICqJckM/f/
7q8ObkjgOnOh16JhnY5VMIldnHIbKzcNKmlljR2wX1juvoiGJelD371iOvwZHpR2
uBwDEYGngZOQDZ89cyQ3Bz3TMm2h04ESZb45CRtZYtkxm7Zuv8qDXzwdmqKxRrzI
e0ThFEMjvRAY55rWinL2iO8Ih98Ue2N9/FKbHfU9gDCc+shol3cijoQesuqToWdP
IGmiIueyOKqi1HFeIW6x8lxi6oMXiSmDnlaNb7ziuknW+coGLgNlc/HeIcmXW07c
f6MFdA+O5nnwy24U5idgn/+HcHG+mFI=
=Y7Px
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to