On 2023-01-27 12:03, Adrian Bunk wrote:
> WITH_SYSTEM_ICU = yes fixes this error on armel.
And on armhf too.
> The build fails later due to 146 TEST-UNEXPECTED-FAIL,
> which is not a problem for 0ad who aren't running the mozjs testsuite.
Of those 146 test failures, many seem to be discrepancies such as:
/build/mozjs78-78.15.0/js/src/tests/non262/Date/shell.js:160:21 Error:
Assertion failed: got "CEST", expected "Central European Summer Time"
/build/mozjs78-78.15.0/js/src/tests/non262/Intl/DisplayNames/dateTimeField.js:141:15
Error: Assertion failed: got "yr", expected "yr."
/build/mozjs78-78.15.0/js/src/tests/non262/Intl/NumberFormat/shell.js:42:21
Error: Assertion failed: got "US$123.00", expected "$123.00": locale=en-CA,
options={"style":"currency","currency":"USD","currencyDisplay":"narrowSymbol"},
value=123
There are a bunch of patches under debian/patches/system-ICU that seem
to deal with those differences such as [1]. Even applying those patches
though, other tests (140+) fail in a similar way.
The presence of those patches under debian/patches/system-ICU seems to
suggest that we don't really care much about the discrepancies. If
that's the case, should we just skip the tests? Any other suggestion for
how to properly move from the embedded ICU to libicu-dev?
[1]
https://sources.debian.org/src/mozjs78/78.15.0-6/debian/patches/system-ICU/tests-Adapt-formatted-strings-results-to-system-ICU.patch/
