Your message dated Sat, 21 Jan 2023 19:09:11 +0000
with message-id <e1pjjel-009ftc...@fasolo.debian.org>
and subject line Bug#1029350: fixed in dh-r 20230121
has caused the Debian Bug report #1029350,
regarding dh-r parsing of tests depends/suggests is faulty
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1029350: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1029350
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: dh-r
Version: 20210816
Severity: serious
Control: retitle -1 dh-r parsing of tests depends/suggests is faulty
Hi Andreas,
On 1/21/23 19:17, Andreas Tille wrote:
Hi,
I'm just running into
dh_auto_install: warning: can't parse dependency spatstat (>= 2.3-3).linnet
(>= 2.0-0)
Can't call method "get_deps" on an undefined value at
/usr/share/perl5/Debian/Debhelper/Buildsystem/R.pm line 51.
when trying to build r-cran-spatstat.core[1]
I've never seen this strange substitution of dependencies before.
Any idea what's wrong here?
Congrats. Looks like you hit a case which catches a bug in dh-R.
The problem is in the code when you are trying to substitute test depends from
the ones in suggests[2]. The substitution
that you are trying to do is also replacing prefixes with versioned dep. Since
there is spatstat and spatstat.linnet both in
d/t/control test-depends, and as you could see spatstat is a common prefix, it
is replacing this with the one
written in DESCRIPTION file which is wrong.
As it seems to me that you only intend to replace non-versioned stuff with the
versioned stuff, maybe you don't have
to replace all strings that are prefix. So _maybe_ a patch like this would do
(it works in this case at least):
diff --git a/dh/R.pm b/dh/R.pm
index 18171ae..7d052b1 100644
--- a/dh/R.pm
+++ b/dh/R.pm
@@ -210,7 +210,7 @@ sub install {
$rsname =~ s/[\s(].*// ;
if ( grep(/^$rsname$/i, @testdeps) ) {
if ( $rs ne $rsname ) { # seems that is a versioned depends that
needs to be propagated to Recommends
- $testdepends =~ s/$rsname */$rs/ ;
+ $testdepends =~ s/$rsname$/$rs/ ;
}
} else {
$newsuggests = $newsuggests . ', ' . $rs ;
But that said, I do not know the essence of this code, and please _triple
check_ and ** do not blindly apply **
[1] https://salsa.debian.org/r-pkg-team/r-cran-spatstat.core/-/jobs/3830571
[2]: https://salsa.debian.org/r-pkg-team/dh-r/-/blob/master/dh/R.pm#L213
Hope that helps.
Thank you
Nilesh
--- End Message ---
--- Begin Message ---
Source: dh-r
Source-Version: 20230121
Done: Andreas Tille <ti...@debian.org>
We believe that the bug you reported is fixed in the latest version of
dh-r, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1029...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andreas Tille <ti...@debian.org> (supplier of updated dh-r package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 21 Jan 2023 17:49:29 +0100
Source: dh-r
Architecture: source
Version: 20230121
Distribution: unstable
Urgency: medium
Maintainer: Debian R Packages Maintainers <r-pkg-t...@alioth-lists.debian.net>
Changed-By: Andreas Tille <ti...@debian.org>
Closes: 1029350
Changes:
dh-r (20230121) unstable; urgency=medium
.
[ Steffen Moeller ]
* s/itp: Warn when executed from wrong directory
* substitute "which" with "command -v" if available
* more checks on runtime errors instead of silent exit
.
[ Andreas Tille ]
* Fix parsing of Test-Depends which are turned into Recommends
Closes: #1029350
* Standards-Version: 4.6.2
Checksums-Sha1:
e8d60eb78c0adf304f30e9910a78871707ea370e 1738 dh-r_20230121.dsc
f4416446d40e8a33184eed56da398ccc589bd11f 40892 dh-r_20230121.tar.xz
2232ac45c2b8b6c9b88de99c12eba8f7e9953b72 5934 dh-r_20230121_amd64.buildinfo
Checksums-Sha256:
b4e27ea895a795984f3675aeb3b17a18616fc75e4f4ae6e2282da03013648125 1738
dh-r_20230121.dsc
81c39e5e12c0a0451812c8c37245dc0456cc8c2b0b32e451bd414f31b5e5f02f 40892
dh-r_20230121.tar.xz
af42a36d3e77f5c62fdf38af0d975c3dc5fb8ad868cf854e5c7c4437be8a4509 5934
dh-r_20230121_amd64.buildinfo
Files:
5f20b846aa1deb8620c8a72dd2d3cd35 1738 science optional dh-r_20230121.dsc
125d0d91e139d2cbc2320c57a51fb977 40892 science optional dh-r_20230121.tar.xz
ce232a682efde5e8aa25a76e6f4343b6 5934 science optional
dh-r_20230121_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCAAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAmPMF8sRHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtFksw//UB1iVuRn4D+p0CCCP6GfLLTlTLKcHpqh
ncjkPSh+x1gVT1jWSIenkoOQMRTcCbPDDeLLnvheFUg9lf6DQrBGt75oEvP+xLSo
JA8jLWqnd7stFKHzceTGNui/Jx4JCq4RFDXEWrjq3P0v+6HS8iWlTIXDjUyLaW67
NRfYVt7XGHoq89zArHA6Rf42d3FZzk9wDmVnlw1lQ2TtNIcOKWczdpua3qGqLixo
1UjUZLz+bheHhlSjFlBQiOMd5hO04B+Y44PL5X/fET/4NyzlS0nSLQvfAqI+PY2t
hzJfdfXSupjF4Xz2wgnmmz9Gw0G2PRvDZI8u2x7mdnvg00cT+KT1St1l7oZjuh/W
J7yPNSNeaiVnAe4/QkZ3AnPWMl/9uH4OsB8b/D4U2ZOJoJPUNDAAHUkv8F4or1cL
5YCHNtvX9Ct3WFKmJIbVF+EVHHQMtQg8hUKxfJbEfS8Wj9pf40u9AM1n7FLBuS/A
cLs8zD+3fE9QqrQJ/0tbXjskJRww3yeUzKJ8SELe5cJEu2YtvJzYps9zWsgbgTLy
VPvvG0QxRGnuK+3TVRdfCDaFAVugyskDLLx93zUF8Y6OqFbf7TbDyusuWMmv9zey
xckmpVGM6dwgz/B/WUAfY3uKZXIHQvJgTuo12VGgXze1gebloMKwoEmvG5fSC9rD
JufeO/WWP1k=
=jx4h
-----END PGP SIGNATURE-----
--- End Message ---
