Control: tags -1 - patch Hi Nilesh,
Nilesh Patra, on 2022-11-24: > On Fri, 18 Nov 2022 22:48:42 +0100 =?utf-8?Q?=C3=89tienne?= Mollier > <emoll...@debian.org> wrote: > > orthanc-dicomweb is currently affected by a failure to build > > from source (Bug#1023738). I took the liberty to have a look, > > and it seems that since axios 1.0 the dist/axios.map file is not > > provided anymore. > > I just did an upload for node-axios that provides the sourcemap file > again with a minor change (/usr/share/nodejs/axios/dist/axios.min.js.map > instead > of min.map) > > However axios code has changed a bit since last version and so has the > sourcemap file. > This needs to be tested with orthanc-dicomweb (if it is even compatible) Thanks for your work on the node-axios front, with some luck, bringing back a map file will be helpful. > > This is causing the following cmake error: > > > > CMake Error at debian/ThirdPartyDownloads/JavaScriptLibraries.cmake:29 > > (file): > > file COPY_FILE failed to copy > > > > /usr/share/nodejs/axios/dist/axios.map > > > > to > > > > /<<PKGBUILDDIR>>/Build/javascript-libs/js/axios.min.map > > > > Scanning through the source code, I noticed that axios.min.map > > file was not used anywhere (only mention is in a cmake file > > which is patched out in Debian context). When removing the > > reference this way, I got the package to build again: > > Looking at the description of node-axios: > > Description: Promise based HTTP client for the browser and node.js > Features: > - Make XMLHttpRequests from the browser > - Make http requests from node.js > - Supports the Promise API > - Intercept request and response > - Transform request and response data > - Cancel requests > - Automatic transforms for JSON data > - Client side support for protecting against XSRF > . > Node.js is an event-based server-side JavaScript engine. > > Looks like axios might be used for an http client which the dicomweb > _probably_ > aims at doing. So removing that file via your patch _might_ not be correct. Thanks for checking in depth, I remove the "patch" tag for now. > But Sebastian is the best judge. Please let us know. Definitely Have a nice day, :) -- Étienne Mollier <emoll...@emlwks999.eu> Fingerprint: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da Sent from /dev/pts/2, please excuse my verbosity. On air: Manticora - 1963. Creator of Failure
signature.asc
Description: PGP signature
