Control: tag -1 + patch pending
Hi,
Axel Beckert wrote:
> > dh_lintian -a
> > Use of uninitialized value $dest in -l at
> > /usr/share/perl5/Debian/Debhelper/Dh_Lib.pm line 662.
> > Use of uninitialized value $to in string eq at
> > /usr/share/perl/5.36/File/Copy.pm line 64.
> > Use of uninitialized value $to in -d at /usr/share/perl/5.36/File/Copy.pm
> > line 96.
> > Use of uninitialized value $dest in concatenation (.) or string at
> > /usr/share/perl5/Debian/Debhelper/Dh_Lib.pm line 665.
> > dh_lintian: error:
> > copy("debian/pconsole/usr/share/lintian/overrides/pconsole", ""): No such
> > file or directory
> > make: *** [debian/rules:12: binary-arch] Error 25
>
> On a first glance this looks like a missed conversion from 3 to 4
> arguments of a call to _install_file_to_path in line 2746 of Dh_Lib.pm:
>
> _install_file_to_path($mode, $source, $target);
>
> I'm trying to find a patch.
Yep, this change makes pconsole and links2 build fine again:
- _install_file_to_path($mode, $source, $target);
+ _install_file_to_path(1, $mode, $source, $target);
I'm though not 100% sure if the 1 is really necessary here of if a 0
would suffice. But the 1 seems to be on the safe side, might be a tiny
performance impact, though.
Will do a bit more testing and then do a team upload of debhelper with
that patch.
Regards, Axel
--
,''`. | Axel Beckert <[email protected]>, https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
