Your message dated Thu, 25 Aug 2022 14:45:34 +0000
with message-id <[email protected]>
and subject line Bug#1017469: fixed in libxsmm 1.17-2
has caused the Debian Bug report #1017469,
regarding libxsmm: FTBFS with undefined reference to pthread_yield
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1017469: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1017469
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libxsmm
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)
User: [email protected]
Usertags: origin-ubuntu kinetic ubuntu-patch
Dear Maintainer,
With glibc >= 2.34, libxsmm FTBFS with an undefined reference to
pthread_yield. Fixes have been committed upstream, but not yet included
in a release.
In Ubuntu, we cherry-picked the upstream commits to fix the build:
* debian/patches: Cherry-pick upstream patches to fix undefined reference to
pthread_yield (LP: #1984111).
Thanks,
Nick
diff -Nru
libxsmm-1.17/debian/patches/0003-Issue-551-rely-on-sched_yield-rather-than-pthread_yi.patch
libxsmm-1.17/debian/patches/0003-Issue-551-rely-on-sched_yield-rather-than-pthread_yi.patch
---
libxsmm-1.17/debian/patches/0003-Issue-551-rely-on-sched_yield-rather-than-pthread_yi.patch
1969-12-31 19:00:00.000000000 -0500
+++
libxsmm-1.17/debian/patches/0003-Issue-551-rely-on-sched_yield-rather-than-pthread_yi.patch
2022-08-09 10:18:54.000000000 -0400
@@ -0,0 +1,25 @@
+Description: rely on sched_yield rather than pthread_yield (GLIBC 2.34 and
later).
+Author: Hans Pabst <[email protected]>
+Origin: upstream,
https://github.com/libxsmm/libxsmm/commit/161ee78f1ccbbe6ce2c0439d6889221cca77ce13
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/libxsmm/+bug/1984111
+Last-Update: 2022-08-09
+---
+
+--- a/include/libxsmm_sync.h
++++ b/include/libxsmm_sync.h
+@@ -462,6 +462,10 @@
+ # define LIBXSMM_TLS_GETVALUE(KEY) pthread_getspecific(KEY)
+ # if defined(__APPLE__) && defined(__MACH__)
+ # define LIBXSMM_SYNC_YIELD pthread_yield_np()
++# elif defined(__GLIBC__) && defined(__GLIBC_MINOR__) \
++ && LIBXSMM_VERSION2(2, 34) <= LIBXSMM_VERSION2(__GLIBC__,
__GLIBC_MINOR__)
++ LIBXSMM_EXTERN int sched_yield(void); /* sched.h */
++# define LIBXSMM_SYNC_YIELD sched_yield()
+ # else
+ # if defined(__USE_GNU) || !defined(__BSD_VISIBLE)
+ LIBXSMM_EXTERN int pthread_yield(void) LIBXSMM_THROW;
+@@ -813,4 +817,3 @@
+ LIBXSMM_API unsigned int libxsmm_get_tid(void);
+
+ #endif /*LIBXSMM_SYNC_H*/
+-
diff -Nru
libxsmm-1.17/debian/patches/0004-Fixed-potential-issue-about-undefined-pthread_yield.patch
libxsmm-1.17/debian/patches/0004-Fixed-potential-issue-about-undefined-pthread_yield.patch
---
libxsmm-1.17/debian/patches/0004-Fixed-potential-issue-about-undefined-pthread_yield.patch
1969-12-31 19:00:00.000000000 -0500
+++
libxsmm-1.17/debian/patches/0004-Fixed-potential-issue-about-undefined-pthread_yield.patch
2022-08-09 10:18:54.000000000 -0400
@@ -0,0 +1,33 @@
+Description: Fixed potential issue about undefined pthread_yield (linkage).
+Author: Hans Pabst <[email protected]>
+Origin: upstream,
https://github.com/libxsmm/libxsmm/commit/304de784a56c3d7763c92b1801e059c3d39e14dc
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/libxsmm/+bug/1984111
+Last-Update: 2022-08-09
+---
+diff --git a/include/libxsmm_macros.h b/include/libxsmm_macros.h
+index 1795ce763..e4d31c9d3 100644
+--- a/include/libxsmm_macros.h
++++ b/include/libxsmm_macros.h
+@@ -844,6 +844,7 @@ LIBXSMM_API_INLINE int libxsmm_nonconst_int(int i) {
return i; }
+ # include <windows.h>
+ # else
+ # include <pthread.h>
++# include <unistd.h>
+ # endif
+ #endif
+ #if !defined(LIBXSMM_ASSERT)
+diff --git a/include/libxsmm_sync.h b/include/libxsmm_sync.h
+index b64a55f09..d92dad2c8 100644
+--- a/include/libxsmm_sync.h
++++ b/include/libxsmm_sync.h
+@@ -466,8 +466,8 @@ typedef enum libxsmm_atomic_kind {
+ # define LIBXSMM_TLS_GETVALUE(KEY) pthread_getspecific(KEY)
+ # if defined(__APPLE__) && defined(__MACH__)
+ # define LIBXSMM_SYNC_YIELD pthread_yield_np()
+-# elif defined(__GLIBC__) && defined(__GLIBC_MINOR__) \
+- && LIBXSMM_VERSION2(2, 34) <= LIBXSMM_VERSION2(__GLIBC__,
__GLIBC_MINOR__)
++# elif defined(_POSIX_PRIORITY_SCHEDULING) || (defined(__GLIBC__) &&
defined(__GLIBC_MINOR__) \
++ && LIBXSMM_VERSION2(2, 34) <= LIBXSMM_VERSION2(__GLIBC__,
__GLIBC_MINOR__))
+ LIBXSMM_EXTERN int sched_yield(void); /* sched.h */
+ # define LIBXSMM_SYNC_YIELD sched_yield()
+ # else
diff -Nru libxsmm-1.17/debian/patches/series libxsmm-1.17/debian/patches/series
--- libxsmm-1.17/debian/patches/series 2022-03-19 19:49:47.000000000 -0400
+++ libxsmm-1.17/debian/patches/series 2022-08-09 10:18:54.000000000 -0400
@@ -1,2 +1,4 @@
0001-Makefile-rebuild-fix.patch
0002-Makefile-fix-pkgconfigdir.patch
+0003-Issue-551-rely-on-sched_yield-rather-than-pthread_yi.patch
+0004-Fixed-potential-issue-about-undefined-pthread_yield.patch
--- End Message ---
--- Begin Message ---
Source: libxsmm
Source-Version: 1.17-2
Done: Boyuan Yang <[email protected]>
We believe that the bug you reported is fixed in the latest version of
libxsmm, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Boyuan Yang <[email protected]> (supplier of updated libxsmm package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 25 Aug 2022 10:20:37 -0400
Source: libxsmm
Architecture: source
Version: 1.17-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers
<[email protected]>
Changed-By: Boyuan Yang <[email protected]>
Closes: 1017469
Changes:
libxsmm (1.17-2) unstable; urgency=medium
.
* debian/control: Bump Standards-Version to 4.6.1.
* Import changes from Ubuntu:
.
[ Nick Rosbrook ]
* debian/patches: Cherry-pick upstream patches to fix undefined reference to
pthread_yield (LP: #1984111) (Closes: #1017469).
Checksums-Sha1:
99246af855bf2e559f464273466d1db9445f8847 2016 libxsmm_1.17-2.dsc
aa92d10675cbff54aacd72a369e540ce85b1badd 2528419 libxsmm_1.17.orig.tar.gz
c6f369d5482330455a969a254d03103588da2c4a 4284 libxsmm_1.17-2.debian.tar.xz
a8455c2643fd729c5a1def6d8f8ed64d1a87ba9d 7238 libxsmm_1.17-2_amd64.buildinfo
Checksums-Sha256:
3775a6df7335229a5584292f0d6a362ffc95f20535d000b72e41b628f9606c8b 2016
libxsmm_1.17-2.dsc
8b642127880e92e8a75400125307724635ecdf4020ca4481e5efe7640451bb92 2528419
libxsmm_1.17.orig.tar.gz
2a94fa7aee2778916ac710a12079af6da3e5fd814231747c15ccceae8bcd8d56 4284
libxsmm_1.17-2.debian.tar.xz
34b15f65fd8326039f209a7ec14c43b8e2065ad71c23611acc13d60765b20612 7238
libxsmm_1.17-2_amd64.buildinfo
Files:
651ad3a43182863f516b4ce7857c8bf9 2016 libs optional libxsmm_1.17-2.dsc
bef3b02f8837b0eed1ea334045da0524 2528419 libs optional libxsmm_1.17.orig.tar.gz
bd33450d62057d60685b0fe9fe630850 4284 libs optional
libxsmm_1.17-2.debian.tar.xz
77ade684f9abae9ddb5a78722d648cfa 7238 libs optional
libxsmm_1.17-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEfncpR22H1vEdkazLwpPntGGCWs4FAmMHhqQACgkQwpPntGGC
Ws7VYQ//f5YLbmD3OVsw1H/qt67eartrRwBB6KqC2aH4MbhUQBn+Kb9CDMTAcqgr
40OFzBXd5kqyi6uDNoD+HYdxdbojF058MniF71SMfhC+lrx0QUYp5D/mkAQ52q11
V2Ggf5szkds6b8NErrXJRhBOH8OfrHJtUGABNfufghy7wvlW3qXwcw2OAFmgiJtR
5INd5eeu8E7rApU5mFO8grpk077X35qeALnpndZ7d8AO7x8S3D8xc8xGt351tQ6a
W9Cshvj9QBWtApxyjn3/6skToYwYBcK8E+QwrVF+L8OD2WlN7RFUdodxSAc+JFKt
vsbgFtyKy2uAXBKoXSn9lDzQAJhWTQaPCE/JItvMsyLxCQqxqLoSfzaLDdieujqQ
z/fSsbPOLUwYjR63kHYwj3Oyt3EAWxqrYSHrFL8qeyoQrYfMMjmpnIQcPiltrIRP
riBQ+EeQAOY0RlZPCc2tjt+eZZ9diH2KnqOm24i4ohKhaQ6tltLdDXH5o4usjsWa
cXxG/dFHw5kn294lNFOh2h3DsVaOTWYNSxMdIF53aNz0PfVrkZ8SCuDdI/Quzr2X
mE3OoRrn5rc4ZTq+YH08kM2VETztoZvP9zan/qlU99+7DhuawuHEQFovmeyLY9Dt
5QfEuWG6QJcl5L2rvQcXJAVa1AoyvnZUvKmoBF3QzrosVRfeaAU=
=VOnS
-----END PGP SIGNATURE-----
--- End Message ---
