control: tag -1 + pending On 2022-08-09 15:12, Aurelien Jarno wrote: > control: tag -1 + patch > > Hi, > > On 2022-08-08 01:34, Sebastian Ramacher wrote: > > Source: libspf2 > > Version: 1.2.10-7.1 > > Severity: serious > > Tags: ftbfs sid bookworm > > Justification: fails to build from source (but built successfully in the > > past) > > X-Debbugs-Cc: sramac...@debian.org > > > > https://buildd.debian.org/status/fetch.php?pkg=libspf2&arch=arm64&ver=1.2.10-7.1%2Bb2&stamp=1659915050&raw=0 > > > > /bin/bash ../../libtool --tag=CC --mode=link gcc -g -O2 > > -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat > > -Werror=format-security -Wall -Wl,-z,relro > > -Wl,--version-script=/<<PKGBUILDDIR>>/debian/libspf2.ver -o spfquery > > spfquery.o ../../src/libspf2/libspf2.la -lpthread -lnsl -lresolv > > libtool: link: gcc -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. > > -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wl,-z > > -Wl,relro -Wl,--version-script=/<<PKGBUILDDIR>>/debian/libspf2.ver -o > > .libs/spfquery spfquery.o ../../src/libspf2/.libs/libspf2.so -lpthread > > -lnsl -lresolv > > /usr/bin/ld: ../../src/libspf2/.libs/libspf2.so: undefined reference to > > `__dn_expand' > > /usr/bin/ld: ../../src/libspf2/.libs/libspf2.so: undefined reference to > > `__dn_skipname' > > It appears that these two symbols have been renamed in glibc 2.34 when > moved from libresolv to libc. Quoting the glibc NEWS file: > > | * Various symbols previously defined in libresolv have been moved to libc > | in order to prepare for libresolv moving entirely into libc (see earlier > | entry for merging libraries into libc). The symbols __dn_comp, > | __dn_expand, __dn_skipname, __res_dnok, __res_hnok, __res_mailok, > | __res_mkquery, __res_nmkquery, __res_nquery, __res_nquerydomain, > | __res_nsearch, __res_nsend, __res_ownok, __res_query, __res_querydomain, > | __res_search, __res_send formerly in libresolv have been renamed and no > | longer have a __ prefix. They are now available in libc. > > libspf2 is using libreplace internally to provide "replacements in case > the OS does not have native libraries that contain (working) copies.". > In that case it takes care to rename dn_expand into __dn_expand and > dn_skipname into __dn_skipname. It appears that with the changes done in > glibc 2.34, libspf2 does not need to use libreplace anymore. Therefore > the following patch from Ubuntu fixes the issue: > > https://patches.ubuntu.com/libs/libspf2/libspf2_1.2.10-7.1ubuntu1.patch
I have uploaded a NMU fixing this issue to DELAYED/2. Please find the corresponding debdiff attached. Also please feel free to ask me to delay or cancel this NMU. Regards, Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurel...@aurel32.net http://www.aurel32.net
diff -Nru libspf2-1.2.10/debian/changelog libspf2-1.2.10/debian/changelog --- libspf2-1.2.10/debian/changelog 2021-08-08 13:46:49.000000000 +0200 +++ libspf2-1.2.10/debian/changelog 2022-08-11 23:05:37.000000000 +0200 @@ -1,3 +1,11 @@ +libspf2 (1.2.10-7.2) unstable; urgency=medium + + * Non-maintainer upload. + * no-libreplace.patch: disable libreplace which is not needed anymore and + causes build failures with glibc 2.34 (Closes: #1016821). + + -- Aurelien Jarno <aure...@debian.org> Thu, 11 Aug 2022 23:05:37 +0200 + libspf2 (1.2.10-7.1) unstable; urgency=medium * Non-maintainer upload. diff -Nru libspf2-1.2.10/debian/patches/no-libreplace.patch libspf2-1.2.10/debian/patches/no-libreplace.patch --- libspf2-1.2.10/debian/patches/no-libreplace.patch 1970-01-01 01:00:00.000000000 +0100 +++ libspf2-1.2.10/debian/patches/no-libreplace.patch 2022-08-11 23:05:37.000000000 +0200 @@ -0,0 +1,19 @@ +Description: Don't use unnecessary libreplace + libreplace isn't providing anything of utility here, it's unconditional and + causing build failures on some architectures. +Author: Steve Langasek <steve.langa...@ubuntu.com> +Last-Updated: 2022-02-24 +Forwarded: no + +Index: libspf2-1.2.10/src/libspf2/Makefile.am +=================================================================== +--- libspf2-1.2.10.orig/src/libspf2/Makefile.am ++++ libspf2-1.2.10/src/libspf2/Makefile.am +@@ -34,7 +34,6 @@ + spf_utils.c \ + spf_win32.c + +-libspf2_la_LIBADD = $(top_builddir)/src/libreplace/libreplace.la + + + diff -Nru libspf2-1.2.10/debian/patches/series libspf2-1.2.10/debian/patches/series --- libspf2-1.2.10/debian/patches/series 2021-08-08 13:46:49.000000000 +0200 +++ libspf2-1.2.10/debian/patches/series 2022-08-11 23:05:37.000000000 +0200 @@ -5,3 +5,4 @@ spf_compile.c-Correct-size-of-ds_avail.patch Sanity-check-for-sprintf.patch Fixed-reverse-macro-modifier.patch +no-libreplace.patch
signature.asc
Description: PGP signature
