There are tons of warnings
The actual error is:
On Fri, Jun 03, 2022 at 10:23:00PM +0200, Andreas Beckmann wrote:
> /var/lib/dkms/dahdi/2.11.1.0.20170917~dfsg-7.5/build/drivers/dahdi/xpp/xbus-core.c:
> In function 'xbus_read_proc_open':
> /var/lib/dkms/dahdi/2.11.1.0.20170917~dfsg-7.5/build/drivers/dahdi/xpp/xbus-core.c:1841:50:
> error: implicit declaration of function 'PDE_DATA'; did you mean
> 'NODE_DATA'? [-Werror=implicit-function-declaration]
> 1841 | return single_open(file, xbus_proc_show, PDE_DATA(inode));
> | ^~~~~~~~
> | NODE_DATA
that is also used in several other places in the code. Need to use
pde_data() in 5.17.
I wrote a patch, and then noticed that the build also fails with 5.18:
CC [M]
/home/tzafrirc/Proj/Salsa/pkg-voip/dahdi-linux/dahdi-linux/drivers/dahdi/wctdm.o
/home/tzafrirc/Proj/Salsa/pkg-voip/dahdi-linux/dahdi-linux/drivers/dahdi/wctdm.c:
In function ‘wctdm_init_one’:
/home/tzafrirc/Proj/Salsa/pkg-voip/dahdi-linux/dahdi-linux/drivers/dahdi/wctdm.c:2657:21:
error: implicit declaration of function ‘pci_alloc_consistent’
[-Werror=implicit-function-declaration]
2657 | wc->writechunk = pci_alloc_consistent(pdev, DAHDI_MAX_CHUNKSIZE * 2
* 2 * 2 * 4, &wc->writedma);
| ^~~~~~~~~~~~~~~~~~~~
/home/tzafrirc/Proj/Salsa/pkg-voip/dahdi-linux/dahdi-linux/drivers/dahdi/wctdm.c:2657:19:
warning: assignment to ‘volatile unsigned int *’ from ‘int’ makes pointer from
integer without a cast [-Wint-conversion]
2657 | wc->writechunk = pci_alloc_consistent(pdev, DAHDI_MAX_CHUNKSIZE * 2
* 2 * 2 * 4, &wc->writedma);
| ^
/home/tzafrirc/Proj/Salsa/pkg-voip/dahdi-linux/dahdi-linux/drivers/dahdi/wctdm.c:2677:5:
error: implicit declaration of function ‘pci_free_consistent’
[-Werror=implicit-function-declaration]
2677 | pci_free_consistent(pdev, DAHDI_MAX_CHUNKSIZE * 2 * 2 * 2 * 4,
(void *)wc->writechunk, wc->writedma);
| ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
BTW: as of two days ago or so, the official git repository and
potentially maybe also the bug tracker for dahdi-linux and dahdi-tools
are in Github:
https://github.com/asterisk/dahdi-linux
https://github.com/asterisk/dahdi-tools
I'm not completely sure what this means about requirements for CLA.
--
mail / xmpp / matrix: tzaf...@cohens.org.il
