Your message dated Fri, 29 Apr 2022 15:53:20 +0000
with message-id <[email protected]>
and subject line Bug#1010236: fixed in xye 0.12.2+dfsg-12
has caused the Debian Bug report #1010236,
regarding xye: Xye is stuck in an infinite loop on arm
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1010236: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1010236
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: xye
Version: 0.12.2+dfsg-9
Severity: grave
Justification: renders package unusable
X-Debbugs-Cc: [email protected]
Dear Maintainer,
Xye relies heavily on x86 specific feature which is signedness of char
type. It builds without errors on armhf and arm64 (and possibly other
architectures that are affected) but hangs in an infinite loop as soon
as "Play" button is pressed. The reason for that is internally all
xy coordinates are represented not by int, but a char. On x86, subtracting
1 from 0 results in -1, on arm 255. This is a root of the problem.
Some examples:
src/xye.cpp:1234
for (j=XYE_VERT-1;j>=0;j--) // j reaches 255 on arm
src/xye:1874
dx= (dx>=XYE_HORZ)?0:(dx<0)?XYE_HORZ-1:dx; // dx is never going to be
less that 0, we can't walk through map's edges
I've spent a while trying to replace chars with ints here and there but I gave
up
after seeing how this platform-specific oddity is deeply embedded in the code.
Initially I managed to get "Play" button to work, but the minions did not move.
Levels containing teleporters were getting stuck in an infinite loop.
I've tried building the program with clang, enabling it's magnificent
-fsanitize=integer feature, that detects (among other things) char overflows.
The log was all red.
The proposed solution is to enforce -fsigned-char in CFLAGS and
CXXFLAGS.
The program worked out of the box, all the issues I've encountered so
far are gone. Tested on armhf and arm64.
--- End Message ---
--- Begin Message ---
Source: xye
Source-Version: 0.12.2+dfsg-12
Done: Stephen Kitt <[email protected]>
We believe that the bug you reported is fixed in the latest version of
xye, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Stephen Kitt <[email protected]> (supplier of updated xye package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 29 Apr 2022 17:30:05 +0200
Source: xye
Architecture: source
Version: 0.12.2+dfsg-12
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <[email protected]>
Changed-By: Stephen Kitt <[email protected]>
Closes: 1010236
Changes:
xye (0.12.2+dfsg-12) unstable; urgency=medium
.
* Force signed chars on all architectures (Xye relies on this).
Closes: #1010236. Thanks to Krzysztof Aleksander Pyrkosz for the fix!
Checksums-Sha1:
020732b1010fd8c0e1ec883cc710933c0ca02aa8 2009 xye_0.12.2+dfsg-12.dsc
21926ee41693fdfd4f0dca8e8112c7919834521c 8516 xye_0.12.2+dfsg-12.debian.tar.xz
e93b5cf1577b98b564bb2df24d338fae750720c5 10568
xye_0.12.2+dfsg-12_source.buildinfo
Checksums-Sha256:
1beb26f09d6e77e29eb9f2857c84f2d08ccbc130a09771517a8cbba3655f05be 2009
xye_0.12.2+dfsg-12.dsc
f25668a606c28a901d7e9d36ed3c982de640073b552704c7d7930eb620ca095d 8516
xye_0.12.2+dfsg-12.debian.tar.xz
9c1d373fb72f08de15a97d13d05836c5b5a2f85612674ebcacf125abf6ec9532 10568
xye_0.12.2+dfsg-12_source.buildinfo
Files:
227ed044e3b0111ceb8964f3ec171383 2009 games optional xye_0.12.2+dfsg-12.dsc
bbf75a70bf20b27b997dfedbaf6a603a 8516 games optional
xye_0.12.2+dfsg-12.debian.tar.xz
701a9f0b1ae6ba94d144051f437a2a0d 10568 games optional
xye_0.12.2+dfsg-12_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmJsBjgACgkQgNMC9Yht
g5zYRhAAlhTDiwT+xZVSfR2uDLlSvgU4rk1UsVPYNDMvRTMN2a9CUa8TVvC7D0nS
v6M3GC7xvkTtVqBpsF6DfNXNYAsDGGBn+p7YfXHhUs8Ijg0J88QZflx/bBeMj4Dn
uF1WX9oLdW3uui4wAS9NOncULlIBd2z06z2QXOn7ctnxuU37IeOVRICSDIGG/XOh
5KrFE2XGbXf5z6J3ZdKw3NjWEoUnckWkefBo+UVI+u1tArr15Xc4B5aoyYyRs6xa
DR+4YlW1LvBNmUuqPR/FqditDAbL5v2DsSvAr1UhA1z64+XYkEkrASLqvkquCZM4
EOkle7dc8ZbLPEr49Ojbh8WYBzw2awEls3ZQh+ggnV4YXE1oCYwi2XzdcohAERuz
Irn07nBzdqTMmCOAmYno8qTM7Ul8pzl0okqxU9FMQ5b4DZiY0Sfdi395d6pspvCs
2hifj+wGIqbwd4J03q7ptxkOMUiTYc8lbOdQKG5k1GgIEml0VV8Cbxkm4cdiZB9f
jWy/nh3EgYWe6QH0ECOvcdvIeRsYYOs1EBIs52qdh991ttuD//RetKPLeiWONMex
TdWTDo2FSRkdFZqdUINwk2yF4MsTHIy/gj739eTJSHpaNpHY1LnBt+FPdM5m5MZ3
HgTZfN1KYJq+9x8jZ79Z6nwQiyp/UIf7RwbFP8PbT/416DWtw2Q=
=9b85
-----END PGP SIGNATURE-----
--- End Message ---
