Your message dated Sat, 12 Feb 2022 10:24:44 +0100
with message-id <[email protected]>
and subject line Re: [Pkg-rust-maintainers] Bug#1003786: bat: missing source
for syntaxes/themes.
has caused the Debian Bug report #1003786,
regarding bat: missing source for syntaxes/themes.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1003786: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003786
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: bat
Severity: serious
While checking on the testing migration of rust source packages I noticed that
librust-bat-dev was uninstallable because the old version of syntect did not
offer all the required features. When I started looking at the issue I noticed
there was a new version of bat.
I started working on packaging the new upstream of bat, unfortunately while
investigating
the changes to debian/copyright.debcargo.hint, I discovered a problem.
tests/integration_tests.rs had references to copyright holders that did not
appear to
be mentioned anywhere else in the source code.
Following the trail, it appears the syntaxes and themes are included in the
source package
in binary form in syntaxes.bin and themes.bin, but their sources are not
included, they
are merely referenced by a .gitmodules file.
Does anyone have any thoughts on the best way to sort this out?
I have held off uploading the new version of bat (and performed a fix upload
for the version
currently in Debian instead) so we have freedom in the content of the orig
tarball when
sorting this out.
--- End Message ---
--- Begin Message ---
Hello,
Le 15/01/2022 à 21:48, peter green a écrit :
> Package: bat
> Severity: serious
>
> While checking on the testing migration of rust source packages I
> noticed that
> librust-bat-dev was uninstallable because the old version of syntect
> did not
> offer all the required features. When I started looking at the issue I
> noticed
> there was a new version of bat.
>
> I started working on packaging the new upstream of bat, unfortunately
> while investigating
> the changes to debian/copyright.debcargo.hint, I discovered a problem.
> tests/integration_tests.rs had references to copyright holders that
> did not appear to
> be mentioned anywhere else in the source code.
>
> Following the trail, it appears the syntaxes and themes are included
> in the source package
> in binary form in syntaxes.bin and themes.bin, but their sources are
> not included, they
> are merely referenced by a .gitmodules file.
>
> Does anyone have any thoughts on the best way to sort this out?
>
I think you are jumping on the gun here ;)
it is clearly documented:
https://github.com/sharkdp/bat/commit/145b99f01c19416b5d6419d6bcf3d51a771a5518
and:
https://github.com/sharkdp/bat/blob/master/README.md
"bash assets/create.sh
# Build a bat binary with modified syntaxes and themes"
as we aren't modifying the theme, I don't think it is worse regenerating these
files.
Cheers,
Sylvestre
--- End Message ---
