On 2021/11/05 06:10, Max Kellermann <m...@blarg.de> wrote: > On 2021/11/05 05:55, Florian Schlichting <f...@debian.org> wrote: > > However, Max: behind this hides another problem, which is why I asked > > Ryan to delete the pid_file configuration: as part of 0.23.3 you added > > the "RuntimeDirectory=mpd" directive to both mpd.service units. In the > > absence of User and Group directives, this causes /run/mpd to change > > ownership from mpd:audio (as created by our > > /usr/lib/tmpfiles.d/mpd.conf) to root:root, which means that mpd would > > have to be run as root in order to be able to create a socket or a > > pidfile (yes, legacy) there. I think that's broken from an upstream > > perspective as well, and only works when running mpd as user. > > True, and the real fix would be to finally cease launching MPD as > root, which is an anachronism.
I gave this a second thought, and I fear that changes like this one break even more setups, which should be avoided in a stable branch. I'll rather revert the "RuntimeDirectory" addition for now in the 0.23.x stable branch. The RuntimeDirectory will be re-added to the to-become-0.24 branch, together with lots of other changes to modernize MPD with systemd (no root startup, a StateDirectory for the state file, CacheDirectory for the database file etc.)
