Your message dated Tue, 19 Oct 2021 15:20:08 +0000
with message-id <e1mcquo-000h2g...@fasolo.debian.org>
and subject line Bug#996764: fixed in util-linux 2.37.2-4
has caused the Debian Bug report #996764,
regarding FTBFS: test misc/swaplabel failure
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
996764: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=996764
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: util-linux
Version: 2.37.2-3
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)
Chris,
Whilst building a local version of util-linux 2.37.2-3, the misc/swaplabel test
failed.
I believe this is caused by the change in behaviour of mkswap, which now
complains on stderr if the provided image contains holes. My build environment
is pbuilder/cowbuilder chroot with /var/cache/pbuilder mounted as
ext3. Apparently the call to fallocate() in tests/ts/misc/swaplabel allocates a
file with holes that mkswap then complains about. The additional, unexpected
text in /build/util-linux-2.37.2/tests/output/misc/swaplabel.err is:
mkswap: <swapfile> contains holes or other unsupported extents.
This swap file can be rejected by kernel on swap activation!
Use --verbose for more details.
which directly causes the failure.
I have worked around it with the attached patch which invokes fallocate() with
the -x flag. Although, I suppose fallocate could be dispensed with and truncate
always used instead.
Best wishes
Mark
-- System Information:
Debian Release: 10.0
Architecture: amd64 (x86_64)
Kernel: Linux 4.19.0-17-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8),
LANGUAGE=en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
Versions of packages util-linux depends on:
ii fdisk 2.33.1-0.1+devuan1~beowulf2
ii libaudit1 1:2.8.4-3
ii libblkid1 2.33.1-0.1+devuan1~beowulf2
ii libc6 2.28-10
ii libcap-ng0 0.7.9-2
ii libeudev1 3.2.9-9~beowulf1
ii libmount1 2.33.1-0.1+devuan1~beowulf2
ii libpam0g 1.3.1-5
ii libselinux1 2.8-1+b1
ii libsmartcols1 2.33.1-0.1+devuan1~beowulf2
ii libtinfo6 6.1+20181013-2+deb10u2
ii libuuid1 2.33.1-0.1+devuan1~beowulf2
ii login 1:4.5-1.1
ii zlib1g 1:1.2.11.dfsg-1
util-linux recommends no packages.
Versions of packages util-linux suggests:
ii dosfstools 4.1-2
ii kbd 2.0.4-4
ii util-linux-locales 2.33.1-0.1+devuan1~beowulf2
-- no debconf information
>From 03a585290d86b74d4861e11569c426362c8b853c Mon Sep 17 00:00:00 2001
From: Mark Hindley <m...@hindley.org.uk>
Date: Sun, 17 Oct 2021 20:25:47 +0100
Subject: [PATCH 1/1] Fix test/misc/swaplabel failure due to change in mkswap
behaviour.
mkswap now warns if the image file has holes. If fallocate is used to create the
file, use POSIX semantics to ensure the file has no holes.
This fixes the test failure
misc: swaplabel ... FAILED (misc/swaplabel)
========= script: /build/util-linux-2.37.2/tests/ts/misc/swaplabel
=================
================= OUTPUT =====================
1 Setting up swapspace version 1, size = 9 pages (9xPGSZ bytes)
2 LABEL=1234567890abcde, UUID=12345678-abcd-abcd-abcd-1234567890ab
3 LABEL: 1234567890abcde
4 UUID: 12345678-abcd-abcd-abcd-1234567890ab
================= EXPECTED ===================
1 Setting up swapspace version 1, size = 9 pages (9xPGSZ bytes)
2 LABEL=1234567890abcde, UUID=12345678-abcd-abcd-abcd-1234567890ab
3 LABEL: 1234567890abcde
4 UUID: 12345678-abcd-abcd-abcd-1234567890ab
================= O/E diff ===================
==============================================
The additional error appears in swaplabel.err:
mkswap: <swapfile> contains holes or other unsupported extents.
This swap file can be rejected by kernel on swap activation!
Use --verbose for more details.
diff --git a/tests/ts/misc/swaplabel b/tests/ts/misc/swaplabel
index 0801cb213..8b1abb5c3 100755
--- a/tests/ts/misc/swaplabel
+++ b/tests/ts/misc/swaplabel
@@ -25,7 +25,7 @@ ts_check_test_command "$TS_HELPER_SYSINFO"
# fallocate does not work on most file systems
function fallocate_or_skip()
{
- $TS_CMD_FALLOCATE -l $1 $2 2>/dev/null || \
+ $TS_CMD_FALLOCATE -x -l $1 $2 2>/dev/null || \
truncate -s $1 $2 || \
ts_skip "no way to create test image"
}
--
2.20.1
--- End Message ---
--- Begin Message ---
Source: util-linux
Source-Version: 2.37.2-4
Done: Chris Hofstaedtler <z...@debian.org>
We believe that the bug you reported is fixed in the latest version of
util-linux, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 996...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Chris Hofstaedtler <z...@debian.org> (supplier of updated util-linux package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 19 Oct 2021 14:02:14 +0000
Source: util-linux
Architecture: source
Version: 2.37.2-4
Distribution: unstable
Urgency: medium
Maintainer: util-linux packagers <util-li...@packages.debian.org>
Changed-By: Chris Hofstaedtler <z...@debian.org>
Closes: 992516 994941 996751 996764
Changes:
util-linux (2.37.2-4) unstable; urgency=medium
.
[ Debian Janitor ]
* Use secure URI in Homepage field.
* Remove 1 obsolete maintscript entry.
* Re-export upstream signing key without extra signatures.
.
[ Chris Hofstaedtler ]
* Add upstream-applied patches for requested features
* Use more passive wording in hardlink.1
* fallocate: Let user choose larger buffers for IO reading
* Update HiFive partition names
Thanks to Alexandre Ghiti, Eduard Bloch (Closes: #994941)
* more: add upstream patch for "Erase line before writing the filename"
Thanks to Vincent Smeets (Closes: #992516)
* Apply upstream patch to remove accidental nbsp from blockdev output
(Closes: #996751)
* Apply upstreamed patch to fix FTBFS with mkswap on ext3 in cowbuilder.
Thanks to Mark Hindley <m...@hindley.org.uk> (Closes: #996764)
Checksums-Sha1:
aafc4f270d0287df55bbee6d09bdeeec1e3ee0a0 4454 util-linux_2.37.2-4.dsc
a225a60195894b9c71a1353bf627edf21621fed4 97648
util-linux_2.37.2-4.debian.tar.xz
122a8e3b8d28bb20e44a4366f338a43e911cd422 7583
util-linux_2.37.2-4_source.buildinfo
Checksums-Sha256:
a312bd385e6730207c6a96808367714af6bd0b318c09b8b87dd5f02f4ba9e91c 4454
util-linux_2.37.2-4.dsc
2639bef2d22c57f6e5394e51f892f7d2df39050d663df4864361fbaac3fd5897 97648
util-linux_2.37.2-4.debian.tar.xz
8d87e30135d23c1715eceb01a3a76d0bf111d861e23dc1a059da54aec4d1cb70 7583
util-linux_2.37.2-4_source.buildinfo
Files:
1c5007267977afae80363d6c82aa3e8d 4454 base required util-linux_2.37.2-4.dsc
cb390a9cd03059feab92194c490f0eba 97648 base required
util-linux_2.37.2-4.debian.tar.xz
c6bc570c30ba364b4e64fa807e8c1e22 7583 base required
util-linux_2.37.2-4_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEfRrP+tnggGycTNOSXBPW25MFLgMFAmFu3FEACgkQXBPW25MF
LgMnhxAAkKngK5hOzyUnaQP9asgYvIulSYl+523lwTenAjaYXcX8dsZ6wup580Sv
XwDsslw98UW/cgtiX+3mb6AgE5YYFbTujwLc5qrPWc/+jiWHpr/ECy5WQLKCLvbp
myeQ7M563vRvon//a+GnEsnbZnlxcquR01XZCbaEvkbbcuxVx9KAPT+NmMd57y6V
LhnkfyqvT4vr3TX7jpsz+Jf3HyAitZP0rFyOb4xl7kMYmlbK6XSGRU1GfCq3kRg0
rIu8wOsSF7OL+fB0oPSjGMK1wP8agsOg3q+Q+WuQZj58Am74ihNh66EpwOCL33we
fn6cGiBHkgIxImZo6LAUmKHn1XyDNpz34K2oEWgBZA2vHxRFWEkNfBOtpxulrQwC
5Dj3xvy5/pwHfniODOu1/y+EVY/2IzszvEFxAh1SdVdYb2+HYOATiXjo50JLSDPS
80sxxP52ysxkYv28BrH1zLtrHXCzlC1+y7WG91fL+y3WW3FTW1utTuzu8o7hnY3P
KGIEm6ila677lIRW4H8eaD/7f76cgAQmKvXvLHvN1x9dgTcBoDHi8a5/qt0YzaLd
EuY3/qiwxky6cCNOIgffcXSNALC6M2ooti2PX6CCNQBafYMH6Hrtqgp4WBElWnSn
R4xkEw4/30l1wauxtWsDEwVHxdbVHGYq0RLocaKHCVaUDLFI0Bo=
=8kHa
-----END PGP SIGNATURE-----
--- End Message ---
