Control: tags -1 patch On 9/29/21 7:42 PM, Bas Couwenberg wrote: > Removal of dap-config broke the libdap autopkgtest: > > autopkgtest [06:50:51]: test command1: set -e ; dap-config --help 2> > /dev/null > autopkgtest [06:50:51]: test command1: [----------------------- > autopkgtest [06:50:51]: test command1: -----------------------] > autopkgtest [06:50:51]: test command1: - - - - - - - - - - results - - - - > - - - - - - > command1 FAIL non-zero exit status 127 > > https://ci.debian.net/data/autopkgtest/testing/amd64/libd/libdap/15607353/log.gz > > This blocks testing migration.
The attached patch fixes the issue by dropping the dap-config test. > The removal also broke the gdal build which uses dap-config to get the > required flags: > > configure:40397: checking for qh_new_qhull in -lqhull > configure:40420: gcc -o conftest -DHAVE_AVX_AT_COMPILE_TIME > -DHAVE_SSSE3_AT_COMPILE_TIME -DHAVE_SSE_AT_COMPILE_TIME -g -O2 > -ffile-prefix-map=/build/gdal-3.3.2+dfsg=. -fstack-protector-strong -Wformat > -Werror=format-security -fvisibility=hidden -Wdate-time -D_FORTIFY_SOURCE=2 > -Wl,-z,relro -Wl,-z,now conftest.c -lqhull -lgeos_c -lodbc -lodbcinst > -lkmlbase -lkmldom -lkmlengine -lkmlxsd -lkmlregionator -lexpat -lxerces-c > -lpthread -lopenjp2 -L/usr/lib/x86_64-linux-gnu/hdf5/serial -lnetcdf > -L/usr/lib/x86_64-linux-gnu/hdf5/serial/lib -lhdf5 -lmfhdfalt -ldfalt -logdi > -lgif -lcharls -lgeotiff -lpng -lcfitsio -lpq -lzstd -llzma -lsqlite3 -lproj > -lsqlite3 -ltiff -ljpeg -ldeflate -lz -lpthread -lm -lrt -ldl -L/usr/lib > -lspatialite -L/usr/lib -ldap++ -lpthread -lrx -lcurl -lxml2 >&5 > /usr/bin/ld: cannot find -ldap++ > /usr/bin/ld: cannot find -lrx > collect2: error: ld returned 1 exit status > > #994670 suggested: > > " > a) Delete dap-config and go without it. Any dap-config users (e.g. > gadap) need to be converted to using pkg-config. > b) Revert your change and drop Multi-Arch: same from libdap-dev. As bad > as this may sound, it doesn't actually break that many practical use > cases as coinstallability of -dev packages is rarely required. > " > > Option a) implies that the dap-config users like gdal are adapted to use > pkg-config before dap-config is removed. > > Please consider re-instating dap-config. gdal has been patched to use pkg-config when dap-config is not available, but that requires #993016 to be fixed again to actually work. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
--- a/debian/tests/control 2021-08-31 12:24:50.000000000 +0200 +++ b/debian/tests/control 2021-09-29 21:36:48.818408161 +0200 @@ -1,7 +1,3 @@ -Test-Command: set -e - ; dap-config --help 2> /dev/null -Depends: libdap-dev - # No args; just check linking ok Test-Command: set -e ; getdap -V 2> /dev/null
