reopen 993016
fixed 993016 libdap/3.20.7-7
found 993016 libdap/3.20.8-1
affects 993016 src:gdal
thanks

On Fri, 27 Aug 2021 12:14:27 +0200 Aurelien Jarno wrote:
> On 2021-08-26 13:27, Bas Couwenberg wrote:
> > Source: libdap
> > Version: 3.20.7-6
> > Severity: serious
> > Tags: upstream
> > Justification: makes the package in question unusable or mostly so
> > 
> > Dear Maintainer,
> > 
> > The recent changes in glibc break libdap and its rdeps:
> > 
> >  In file included from /usr/include/libdap/XDRUtils.h:37,
> >                   from /usr/include/libdap/Sequence.h:50,
> >                   from libdap_headers.h:52,
> >                   from ogr_dods.h:44,
> >                   from ogrdodsdriver.cpp:29:
> >  /usr/include/libdap/xdr-datatypes.h:16:10: fatal error: rpc/types.h: No 
> > such file or directory
> >     16 | #include <rpc/types.h>
> >        |          ^~~~~~~~~~~~~
> > 
> > /usr/include/rpc/types.h was provided by libc6-dev in bullseye, but it is 
> > no longer included in libc6-dev (2.31-17).
> 
> The problem is that libdap has proper TI RPC support, but it doesn't
> export that information properly to libdap.pc and dap-config, sorry
> about that.
> 
> Please find a patch attached to fix that.

The removal of dap-config in 3.20.8-1 also dropped the pkg-config
changes for tirpc:

 # tail -5 /usr/lib/x86_64-linux-gnu/pkgconfig/libdap.pc
 Version: 3.20.8
 Libs: -L${libdir} -ldap
 Libs.private:   -lpthread
 Requires.private: libxml-2.0 >= 2.7.0
 Cflags: -I${includedir}/libdap

The attached patch fixes the issue by reinstating Aurelien's patch in
the series file and updating it to apply to dap-config.in.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1
diff -Nru libdap-3.20.8/debian/changelog libdap-3.20.8/debian/changelog
--- libdap-3.20.8/debian/changelog      2021-09-21 13:55:59.000000000 +0200
+++ libdap-3.20.8/debian/changelog      2021-09-29 21:00:08.000000000 +0200
@@ -1,3 +1,11 @@
+libdap (3.20.8-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Re-instate tirpc patch.
+    (closes: #993016)
+
+ -- Bas Couwenberg <sebas...@debian.org>  Wed, 29 Sep 2021 21:00:08 +0200
+
 libdap (3.20.8-1) unstable; urgency=medium
 
   * New upstream release
diff -Nru libdap-3.20.8/debian/patches/series 
libdap-3.20.8/debian/patches/series
--- libdap-3.20.8/debian/patches/series 2021-09-21 13:55:59.000000000 +0200
+++ libdap-3.20.8/debian/patches/series 2021-09-29 20:59:01.000000000 +0200
@@ -4,3 +4,4 @@
 disable-dmr-tests.patch
 disable-net-tests.patch
 disable-D4FilterClauseTest.patch
+tirpc-cflags-libs.patch
diff -Nru libdap-3.20.8/debian/patches/tirpc-cflags-libs.patch 
libdap-3.20.8/debian/patches/tirpc-cflags-libs.patch
--- libdap-3.20.8/debian/patches/tirpc-cflags-libs.patch        2021-09-21 
13:55:59.000000000 +0200
+++ libdap-3.20.8/debian/patches/tirpc-cflags-libs.patch        2021-09-29 
21:00:04.000000000 +0200
@@ -5,7 +5,7 @@
 
 --- a/conf/acinclude.m4
 +++ b/conf/acinclude.m4
-@@ -560,13 +560,15 @@
+@@ -560,13 +560,15 @@ AC_DEFUN([DODS_CHECK_SIZES], [dnl
  
      # First, we need to see if the xdr routines are in libtirpc, libc, librpc,
      # or librpcsvc or libnsl
@@ -22,7 +22,7 @@
                [dap_xdrlib=""]
        )
        AS_IF(
-@@ -574,6 +576,7 @@
+@@ -574,6 +576,7 @@ AC_DEFUN([DODS_CHECK_SIZES], [dnl
        [AC_SEARCH_LIBS([xdr_void],[c rpc nsl rpcsvc],[
          dap_xdrlib=`echo $ac_res|sed -e 's/^-l//'`],[
          AC_MSG_WARN(Cannot locate library containing xdr functions.)])])
@@ -32,18 +32,18 @@
      if test -z "$dap_xdrlib" ; then dap_xdrlib=c; fi
 --- a/dap-config.in
 +++ b/dap-config.in
-@@ -56,7 +56,7 @@
-       ;;
- 
+@@ -59,7 +59,7 @@ while test $# -gt 0; do
+     # which avoids issues with IDE warnings and will help later when there are
+     # two libdap libraries. jhrg 6/17/21
      --cflags)
--      echo "-I${includedir}/libdap @XML2_CFLAGS@ @CURL_CFLAGS@"
-+      echo "-I${includedir}/libdap @XML2_CFLAGS@ @CURL_CFLAGS@ @TIRPC_CFLAGS@"
+-      echo "-I${includedir} -I${includedir}/libdap @XML2_CFLAGS@ 
@CURL_CFLAGS@"
++      echo "-I${includedir} -I${includedir}/libdap @XML2_CFLAGS@ 
@CURL_CFLAGS@ @TIRPC_CFLAGS@"
        ;;
  
      --libs)
 --- a/libdap.pc.in
 +++ b/libdap.pc.in
-@@ -10,6 +10,7 @@
+@@ -10,6 +10,7 @@ Description: Common items for the OPeNDA
  Version: @VERSION@
  Libs: -L${libdir} -ldap
  Libs.private:  @xmlprivatelibs@ @PTHREAD_LIBS@

Reply via email to