Cyril Brulebois, le jeu. 29 avril 2021 18:54:56 +0200, a ecrit:
> Versions 1.44, 1.44.2, and 1.44.3 all fail in a similar way:
>
> ../pango/pangofc-font.c: In function ‘get_face_metrics’:
> ../pango/pangofc-font.c:371:44: error: ‘HB_OT_METRICS_UNDERLINE_SIZE’
> undeclared (first use in this function); did you mean
> ‘HB_OT_METRICS_TAG_UNDERLINE_SIZE’?
It seems it was just a renaming at some hb point, pango later got
commit d835004502c801a8a16cc436a38900e548ecde52
Author: Ebrahim Byagowi <ebra...@gnu.org>
Date: Sat Aug 10 14:05:40 2019 +0430
Use latest version of metrics naming in pangofc-font
diff --git a/pango/pangofc-font.c b/pango/pangofc-font.c
index 98e77288..21644b57 100644
--- a/pango/pangofc-font.c
+++ b/pango/pangofc-font.c
@@ -365,16 +365,16 @@ get_face_metrics (PangoFcFont *fcfont,
#if HB_VERSION_ATLEAST(2,5,4)
hb_position_t position;
- if (hb_ot_metrics_get_position (hb_font, HB_OT_METRICS_UNDERLINE_SIZE,
&position))
+ if (hb_ot_metrics_get_position (hb_font, HB_OT_METRICS_TAG_UNDERLINE_SIZE,
&position))
metrics->underline_thickness = position;
- if (hb_ot_metrics_get_position (hb_font, HB_OT_METRICS_UNDERLINE_OFFSET,
&position))
+ if (hb_ot_metrics_get_position (hb_font, HB_OT_METRICS_TAG_UNDERLINE_OFFSET,
&position))
metrics->underline_position = position;
- if (hb_ot_metrics_get_position (hb_font, HB_OT_METRICS_STRIKEOUT_SIZE,
&position))
+ if (hb_ot_metrics_get_position (hb_font, HB_OT_METRICS_TAG_STRIKEOUT_SIZE,
&position))
metrics->strikethrough_thickness = position;
- if (hb_ot_metrics_get_position (hb_font, HB_OT_METRICS_STRIKEOUT_OFFSET,
&position))
+ if (hb_ot_metrics_get_position (hb_font, HB_OT_METRICS_TAG_STRIKEOUT_OFFSET,
&position))
metrics->strikethrough_position = position;
#endif
}
which probably can thus be used as it is.
Samuel
