Control: affects -1 = Control: clone -1 -2 Control: reassign -2 src:sysvinit Control: retitle -2 sysvinit FTBFS: broken check for presence of -lcrypt Control: tags -2 + patch Control: tags -1 - ftbfs Control: retitle -1 libcrypt-dev misplaced pkg-config files
On Sun, Apr 18, 2021 at 10:44:17AM +0200, Helmut Grohne wrote: > One aspect to this certainly is that the .pc files are now located in > /lib, which is wrong as pkg-config does not search that directory. I've > attempted fixing this aspect and am attaching a patch for that. > Unfortunately, this does not fix sysvinit. There must be something else > to this. I looked into the sysvinit side now and the way it detectd -lcrypt is ... broken. It quite simply cannot be fixed in libxcrypt. Please find a patch for sysvinit attached that fixes the ftbfs in a general way, that is without hardcoding random library search paths. I've cloned a bug for this as -2. I'm leaving the original -1 bug around, because the issue around pkg-config files needs to be addressed as well. What a mess. Helmut
--- sysvinit-2.96.orig/src/Makefile +++ sysvinit-2.96/src/Makefile @@ -89,15 +89,8 @@ SULOGINLIBS = endif -# Additional libs for GNU libc. -ifneq ($(wildcard /usr/lib*/libcrypt.*),) - SULOGINLIBS += -lcrypt -endif - -# Additional libs for GNU libc / multiarch on Debian based systems. -ifneq ($(wildcard /usr/lib/*/libcrypt.*),) - SULOGINLIBS += -lcrypt -endif +# Add -lcrypt if available. Needed with GNU libc or libxcrypt. +SULOGINLIBS += $(shell $(CC) -shared -x c /dev/null -o /dev/null -lcrypt 2>/dev/null && echo -lcrypt) all: $(BIN) $(SBIN) $(USRBIN)
