Package: golang-github-go-ping-ping
Version: 0+git20201106.b6486c6-2
Severity: serious
Tags: patch
Justification: Policy 4.9
User: [email protected]
Usertags: origin-ubuntu hirsute ubuntu-patch
Hi,
python-rfc6555 currently requires network access during build for some of its
tests, which causes the build to fail in Ubuntu [1] (and reproducible
builds [2]) and is a violation of Debian policy.
In Ubuntu, the attached patch was applied to achieve the following:
* d/p/skip-tests-requiring-network-access.patch: Skip tests that require
network access since Ubuntu's buildds don't have it.
Thanks for considering the patch.
Logan
[1]
https://launchpad.net/ubuntu/+source/golang-github-go-ping-ping/0+git20201106.b6486c6-2/+build/20988534
[2]
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/golang-github-go-ping-ping.html
diff -Nru
golang-github-go-ping-ping-0+git20201106.b6486c6/debian/patches/series
golang-github-go-ping-ping-0+git20201106.b6486c6/debian/patches/series
--- golang-github-go-ping-ping-0+git20201106.b6486c6/debian/patches/series
1969-12-31 19:00:00.000000000 -0500
+++ golang-github-go-ping-ping-0+git20201106.b6486c6/debian/patches/series
2021-02-20 23:04:52.000000000 -0500
@@ -0,0 +1 @@
+skip-tests-requiring-network-access.patch
diff -Nru
golang-github-go-ping-ping-0+git20201106.b6486c6/debian/patches/skip-tests-requiring-network-access.patch
golang-github-go-ping-ping-0+git20201106.b6486c6/debian/patches/skip-tests-requiring-network-access.patch
---
golang-github-go-ping-ping-0+git20201106.b6486c6/debian/patches/skip-tests-requiring-network-access.patch
1969-12-31 19:00:00.000000000 -0500
+++
golang-github-go-ping-ping-0+git20201106.b6486c6/debian/patches/skip-tests-requiring-network-access.patch
2021-02-20 23:05:17.000000000 -0500
@@ -0,0 +1,18 @@
+--- a/ping_test.go
++++ b/ping_test.go
+@@ -227,6 +227,7 @@
+ }
+
+ func TestNewPingerValid(t *testing.T) {
++ t.Skip("Requires network access")
+ p := New("www.google.com")
+ err := p.Resolve()
+ AssertNoError(t, err)
+@@ -344,6 +345,7 @@
+ }
+
+ func TestSetIPAddr(t *testing.T) {
++ t.Skip("Requires network access")
+ googleaddr, err := net.ResolveIPAddr("ip", "www.google.com")
+ if err != nil {
+ t.Fatal("Can't resolve www.google.com, can't run tests")
