Control: severity -1 normal Control: tags -1 moreinfo Dennis Braun: > Package: debhelper > Version: 13 > Severity: serious > Tags: upstream ftbfs > Justification: fails to build from source > > Dear Maintainer, > > when upgrading to dh 13 with ebumeter, dh complains about source files from > ebumeter/source missing in the binary. > > https://salsa.debian.org/multimedia-team/ebumeter > > Best regards, > Dennis > > > [...] Hi Dennis,
This bug report leaves me with very mixed feelings. The report has no details of what you did other than a vague "Upgrading to dh" which is ambiguous (did you upgrade to debhelper 13 or bump compat level to 13? There is a major difference between the two). There are no details of what you did to understand the problem nor any mention of unclear documentation from debhelper's documentation. This leaves me with the feeling that you bumped the compat level without reading the relevant documentation and when it broke you shoved the broken pieces to me with an implicit "Please fix this for me!". This is hopefully not what you intended to do. In the future, I would recommend you provide a bit more details on what you have tried to do or/and which part of the documentation that you do not feel match the reality you see. This would leave me with less guess work and also less likely to come to the above assumption that cannot be part of a fruitful discussion on how we fix the issue you experience. *Moving on* Pushing that aside, lets move on to ebumeter. I presume what you were experiencing was that dh_missing terminated when an error as it now defaults to --fail-missing instead of --list-missing. This is documented in "man 7 debhelper" under "Supported compatibility levels" (see the "v13" / "Changes from v12" entry). Related, dh_missing emits the same warnings already under compat 12, which is an early warning and would have enabled you to fix this problem ahead of time. I can recommend checking the build logs for warnings before bumping compat levels. At this point, we might be tempted to just neuter the dh_missing issue (instructions are in "man 7 debhelper") and move on. However, I recommend that you fix the root cause, which in this case involves the --sourcedir parameter to dh and some follow up fixes. *The root cause for ebumeter* The "--sourcedir" parameter is accepted by dh_install AND the dh_auto_* commands. But in ebumeter, it *seem* to be used to make sure dh_auto_* pick up the upstream source files directly. This can be done by using the longer form "--sourcedirectory", which only dh_auto_* responds to[1]. This will trigger some errors from the .install and .manpages files because the "../" hack does not work any longer. That said, it is unneeded and simply removing "../" will work because the relevant dh_install* helpers will fall back to the source root when they do not get the --sourcedir parameter. These changes should also work in compat 12, so you can try them out without bumping to compat 13 and see all the dh_missing warnings disappear. Note: I have made no attempts to check if the package work after these changes and include every thing as you would expect. I leave that to you. *In summary* I do not see a bug in debhelper, only a failed attempt to migrate to compat 13 (which I have provided suggestions on how to fix). Should you find that the documentation for bumping compat levels is unclear or have suggestions to improve it, please let me know and I will look at fixing it. ~Niels [1] Yes, it is confusing that --sourcedir is picked up by both dh_install + dh_auto_*.
