Your message dated Tue, 01 Oct 2019 05:19:22 +0000
with message-id <e1ifazg-0007ly...@fasolo.debian.org>
and subject line Bug#940163: fixed in dee 1.2.7+17.10.20170616-6
has caused the Debian Bug report #940163,
regarding dee: FTBFS with GLib 2.62: uses deprecated
G_TYPE_INSTANCE_GET_PRIVATE with -Werror
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
940163: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=940163
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: dee
Version: 1.2.7+17.10.20170616-4
Severity: important
Tags: ftbfs
Control: block 940161 by -1
To reproduce, build dee against glib2.0 2.62.x, currently in experimental.
glib2.0 2.62.x is part of GNOME 3.34 and will be uploaded to unstable soon,
at which point this bug will become RC.
dee uses compiler options that include -Werror,
-Wno-error=deprecated-declarations and -DG_DISABLE_DEPRECATED:
> libtool: compile: gcc -DHAVE_CONFIG_H
> -I. -I.. -I. -I.. -I.. -DG_LOG_DOMAIN=\"dee\" -DPREFIX=\"/usr\"
> -DLIBDIR=\"/usr/lib/x86_64-linux-gnu\" -DG_DISABLE_DEPRECATED
> -DDEE_COMPILATION -g -Wall -pthread -I/usr/include/gio-unix-2.0
> -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0
> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Werror -Wall -Wcast-align
> -Wno-uninitialized -Wempty-body -Wformat-security -Winit-self
> -Wno-error=deprecated-declarations -Wdate-time -D_FORTIFY_SOURCE=2 -g
> -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong
> -Wformat -Werror=format-security -c dee-analyzer.c -fPIC -DPIC -o
> .libs/libdee_1_0_la-dee-analyzer.o
GLib 2.62.x has started to apply deprecation warning markers to
deprecated non-declaration constructs, such as macros and types. In
particular this affects the G_TYPE_INSTANCE_GET_PRIVATE macro,
which is part of the implementation of older conventional macros like
DEE_ANALYZER_GET_PRIVATE. Because this is not actually a declaration,
it is unaffected by -Wno-error=deprecated-declarations:
> dee-analyzer.c: In function ‘dee_analyzer_class_init’:
> dee-analyzer.c:200:3: warning: ‘g_type_class_add_private’ is deprecated
> [-Wdeprecated-declarations]
> 200 | g_type_class_add_private (obj_class, sizeof (DeeAnalyzerPrivate));
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> In file included from /usr/include/glib-2.0/gobject/gobject.h:24,
> from /usr/include/glib-2.0/gobject/gbinding.h:29,
> from /usr/include/glib-2.0/glib-object.h:23,
> from dee-analyzer.h:28,
> from dee-analyzer.c:46:
> /usr/include/glib-2.0/gobject/gtype.h:1308:10: note: declared here
> 1308 | void g_type_class_add_private (gpointer
> g_class,
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> dee-analyzer.c: In function ‘dee_analyzer_init’:
> dee-analyzer.c:208:13: error: G_ADD_PRIVATE [-Werror]
> 208 | priv = self->priv = DEE_ANALYZER_GET_PRIVATE (self);
> | ^~~~~~~~~~~~~~~
The obvious solution is to stop compiling distro packages with -Werror,
which is nearly always a RC bug waiting to happen. Untested patch:
pass --disable-maintainer-flags to dh_auto_configure.
Using -DG_DISABLE_DEPRECATED in distro packages is likely also a bad idea:
if the GLib maintainers had used the older way to deprecate a macro
#ifndef G_DISABLE_DEPRECATED
#define G_TYPE_INSTANCE_GET_PRIVATE ...
#endif
then this code would still FTBFS, but for a different reason.
smcv
--- End Message ---
--- Begin Message ---
Source: dee
Source-Version: 1.2.7+17.10.20170616-6
We believe that the bug you reported is fixed in the latest version of
dee, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 940...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Kartik Mistry <kar...@debian.org> (supplier of updated dee package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 30 Sep 2019 23:12:16 +0530
Source: dee
Architecture: source
Version: 1.2.7+17.10.20170616-6
Distribution: unstable
Urgency: low
Maintainer: Kartik Mistry <kar...@debian.org>
Changed-By: Kartik Mistry <kar...@debian.org>
Closes: 936379 940163
Changes:
dee (1.2.7+17.10.20170616-6) unstable; urgency=low
.
* Bumped dh to 12.
* Updated Standards-Version to 4.4.0
* Added patches from Ubuntu:
+ build_no_werror.patch: Don't build with Werror (Closes: #940163)
+ vapi-skip-properties.patch: Disable properties that fail to build
on newer versions of Vala and aren't required.
* Removed python2 support (Closes: #936379)
* debian/rules:
+ Update for dh 12.
* Updated examples.
Checksums-Sha1:
23f26870995885ecc12275b8f93d2ccbf7c1ba50 2401 dee_1.2.7+17.10.20170616-6.dsc
6e0705a22032655568feef0e4421a85863e8622b 14156
dee_1.2.7+17.10.20170616-6.debian.tar.xz
Checksums-Sha256:
d165ece57745603f149a912a3b763eaf7fc7dfd24cfe8af07afe9fb2e69dd234 2401
dee_1.2.7+17.10.20170616-6.dsc
6bda6d461b04ad1dbfcc5b2275a30aeba055f0eeb0f72d3b1121c6e443021d88 14156
dee_1.2.7+17.10.20170616-6.debian.tar.xz
Files:
9e63578df3b7715b35496d47accadf9f 2401 libs optional
dee_1.2.7+17.10.20170616-6.dsc
e8737d70bbf73d82c89ba961fe156a3d 14156 libs optional
dee_1.2.7+17.10.20170616-6.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEa2MbXvVUr2sRlmKSAsHT8ng6pN4FAl2S3ZgACgkQAsHT8ng6
pN7Xfg/+PpRjVW/qoYfQh1BPt9+DM1buJjhumKiDY3qZCksK/Iw3TYPFD6obJWcC
qR9RImHJ63cgidN9iVQTFZFA5y+J/FLfmNRgoOSfZrpt2KLJRiqFztZixz7OgPeU
6vYp783em1oMdzMDUbPS24RtBPYkXbSixbFKOOgbDrzMA6nQIiStmuyZ7X1JBPd6
YjiIfqZYBK3T6qrdegt5RqJ+9pfWdVmflpyUyugupBdeGyyn+5HpUaJHHzRHH65V
cOim6HhTsNyrrNpG3mvNo803mg+mLEyB8Unrbgi0pTR7nH1TMfaJUq6Dc9AsCORG
O/phwz0J1mcm6AYRby/g0Zb8Qc2gFKbuJWDbsylg2mTYL5nwCIZ+zyJjrsH/y8zk
PpcJ3u+0Or+FAVAqEwTU1VSLiVb36GbJ2rY3kW1HdHwHmkRR7D/3O4B4UBv2zQH/
+wYoklBYqoMN7Qo60vLn7O10OercrN+w4uj9TqcioB9Ns/dv8pJb/NFmwYV4EVOL
J1VrzLyyuq6fAYxSIYgeTQfsZ71krXIsXO86Zbztc653iltvx4m+QY1vxmkxQRY5
AevWDh8UAHGr3WDYCbMAZDsUvMxVLxI7LaFuNMlKZvr9asG/SHo0QMtVtPxUpNco
tknNIKaDqBHW/OwU7lLD+o1uIEBVaEwqMo/F8chfDtqEC27FY/0=
=NERA
-----END PGP SIGNATURE-----
--- End Message ---
