Source: lollypop
Version: 1.1.4.16-1
Severity: grave
Tags: patch
without python3-gi installed:
$ lollypop
Traceback (most recent call last):
File "/usr/bin/lollypop", line 14, in <module>
from gi.repository import Gio
ModuleNotFoundError: No module named 'gi.repository'
IOW: the package needs python3-gi to run.
OTOH gobject-introspection is *not* required.
There are a several more wrong more dependencies and build-dependencies:
- all the lib*-dev packages are *not* required
(meson.build is wrong, there's nothing to compile here)
- instead several gir1.2-* packages are required
(the contain the *.typelib files required for using gobject introspection
with the correspnding libraries)
- libglib2.0-dev-bin is required for the build
(it provides glib-compile-resources required to compile resource files)
- python-sqlite is totally wrong: it contains a Python binding to the
obsolete SQLite2 library (and is python2 only); lollypop uses
import sqlite3
which is a Python binding for the SQLite3 library provided
by package libpython3-stdlib which is already covered
as a dependency of package python3
Patch (for meson.build and debian/control) attached.
Cheers, Roderich
-- System Information:
Debian Release: bullseye/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 5.3.0-rc7 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
-- no debconf information
--- a/debian/control
+++ b/debian/control
@@ -7,17 +7,15 @@
python3,
dh-python,
meson,
- libglib2.0-dev,
- libgirepository1.0-dev,
- libgtk-3-dev,
- gnome-common,
gir1.2-gstreamer-1.0,
- libappstream-glib-dev,
- python3-cairo,
- python3-pil,
+ gir1.2-secret-1,
+ gir1.2-totemplparser-1.0,
+ libglib2.0-dev-bin,
+ python3,
python3-bs4,
+ python3-gi,
+ python3-pil,
python3-pylast,
- libtotem-plparser-dev,
appstream-util,
Standards-Version: 4.4.0
Homepage: https://wiki.gnome.org/Apps/Lollypop
@@ -28,14 +26,14 @@
Architecture: all
Depends: ${python3:Depends},
${misc:Depends},
- gir1.2-totemplparser-1.0,
- gobject-introspection,
- python3-pylast,
+ gir1.2-gstreamer-1.0,
gir1.2-secret-1,
+ gir1.2-totemplparser-1.0,
python3,
- python3-pil,
python3-bs4,
- python-sqlite
+ python3-gi,
+ python3-pil,
+ python3-pylast,
Description: modern music player
A Music player for GNOME featuring intuitive browsing of your music
collection. Supports downloading of lyrics and cover art, syncing music
--- a/meson.build
+++ b/meson.build
@@ -13,9 +13,6 @@
else
message('Found python3 binary')
endif
-dependency('glib-2.0')
-dependency('gobject-introspection-1.0', version: '>=1.35.9')
-dependency('gtk+-3.0', version :'>=3.20')
python_dir = join_paths(get_option('prefix'), python.sysconfig_path('purelib'))
LIBEXEC_DIR = join_paths(get_option('prefix'), get_option('libexecdir'))
