Your message dated Sun, 24 Mar 2019 13:04:47 +0000
with message-id <e1h82nv-000a6a...@fasolo.debian.org>
and subject line Bug#924291: fixed in netrek-client-cow 3.3.1-3
has caused the Debian Bug report #924291,
regarding netrek-client-cow: build can loop indefinitely on failure
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
924291: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924291
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: netrek-client-cow
Version: 3.3.1-1
Severity: serious
Justification: breaks build infrastructure
When mkkey fails to run, netrek-client-cow has a very bad failure mode.
It loops until mkkey succeeds:
| until ./mkkey key.cow.linux "Client Of Win" "automatic packaged key"
"qu...@us.netrek.org" "netrek.org/files/COW/" "inl,standard2"; do sleep 1; done
When mkkey fails reliably and produces output, this causes the build to
run indefinitely as sbuild only abort a build that has no output for a
prologned time. This behaviour can make buildds and QA infrastructure
hang.
I suggest using a bounded loop and failing hard after a number of
attempts. That's a very simple solution to the problem at hand. For
instance:
| attempts=32; until ./mkkey ...; do attempts=$((attempts - 1)); test $attempts
-le 0 && exit 1; sleep 1; done
Furthermore I question why a key should be created at build time and
then be distributed to consumers of the package. That seems to run
counter to the concept of a "key". If the key is to protect anything, it
must not be public. Maybe the best course of action would be not
creating this key at all during build.
Helmut
--- End Message ---
--- Begin Message ---
Source: netrek-client-cow
Source-Version: 3.3.1-3
We believe that the bug you reported is fixed in the latest version of
netrek-client-cow, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 924...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Markus Koschany <a...@debian.org> (supplier of updated netrek-client-cow
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 24 Mar 2019 13:31:40 +0100
Source: netrek-client-cow
Architecture: source
Version: 3.3.1-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-de...@lists.alioth.debian.org>
Changed-By: Markus Koschany <a...@debian.org>
Closes: 924291
Changes:
netrek-client-cow (3.3.1-3) unstable; urgency=medium
.
* Team upload.
* Fix infinite loop patch. Really (Closes: #924291)
Checksums-Sha1:
8921b5dae4e9c2ceb62f7365e4d463df7b1cca4c 2244 netrek-client-cow_3.3.1-3.dsc
5e3b60b401c0c0da4791e77eefd5557824f598e9 7100
netrek-client-cow_3.3.1-3.debian.tar.xz
658db11c3d2e30b5e076cc8a200b6d26ceaa0177 11613
netrek-client-cow_3.3.1-3_amd64.buildinfo
Checksums-Sha256:
9972ab3ca5871858f68bd94019a1675618b569525ed209baecee48d12e72b163 2244
netrek-client-cow_3.3.1-3.dsc
e03bfcfaeede975eea5a2a7ce8d3b2e42578075e6a866bbf1a26dce2d45eb762 7100
netrek-client-cow_3.3.1-3.debian.tar.xz
481157d77506a1f88db45b53f609f75344b407e6a47b03155f5912c3e4578802 11613
netrek-client-cow_3.3.1-3_amd64.buildinfo
Files:
c502091d942f3cbaf12496ac9772fc9c 2244 games optional
netrek-client-cow_3.3.1-3.dsc
069f2fecb8a54ab2e2a7c6347f9ea2ab 7100 games optional
netrek-client-cow_3.3.1-3.debian.tar.xz
26af1186249b9170267dee8c6e8098c7 11613 games optional
netrek-client-cow_3.3.1-3_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQKjBAEBCgCNFiEErPPQiO8y7e9qGoNf2a0UuVE7UeQFAlyXe1BfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEFD
RjNEMDg4RUYzMkVERUY2QTFBODM1RkQ5QUQxNEI5NTEzQjUxRTQPHGFwb0BkZWJp
YW4ub3JnAAoJENmtFLlRO1HksD8QAKqbakgoDJMqmO14LZu6+9He9KgQWA0knmTN
mfqNVQYjdXOn1krcDypQSYqoTNoVzID3gSQHyGBMOIez6XWSkTbtvRh1FE9bptW7
JCZfHgC+QsuDHN3l/bOGhKXEhXDkKJKe04Y9IsVSSmkmVPkcPIuPDpGaf/De4X35
kyTyyQUcuNW/5L2NBKO9w3JspLq3Ykgx3WUo0kyGoaNxprqI5AhqjO8hEAaQIep1
6RuYRKRiQCKQmYQ+rSFATs1G4HPPdfev8FvjFJtV1hjpDdG+4pweNJHepSAKLglh
8czBlj4gi20Cn/1jFbCSAWaIT9wQ7j79jM9ZtFR7QWW01tvWXwqxr2lU9LB2u6OV
wol8d8wJ2WjUIkINRZplj8KOhz+RkZ847/9KvMGdSfjueJS9sFWSztFvi1u8YO2a
Oo52akuj8zhnyLmr8MyWKmwUTlZ8HOO5ZC8nFkAU+sZzHHCTmkPiPkITwvYVZMdB
FYGWcGP/k76OElZsivZGRKb6WYADzfrQZJTHAVP8C4z67MG5I8jto/TTWh1u8znw
NgoE7r9ftYa+KR2N2xMGysi5CwdQm5Op+59Q8NlQuQDwqh4TZ/TdhfEfH9r3hTmZ
HddKRtvamHM45Bl14uchq/+fox7qitdlNM/xIHXDojk/i5pgp8g4H1s24qC92aiy
e/Q+Ewg6
=GBK5
-----END PGP SIGNATURE-----
--- End Message ---
