control: tags -1 +moreinfo
[2019-02-06 20:20] Andreas Metzler <ametz...@bebt.de> > Package: lsb-base > Version: 10.2018112800 > Severity: serious > > Hello, > > there is a logic error in /lib/lsb/init-functions's killproc: > > base=${1##*/} > if [ ! $pidfile ]; then > name_param="--name $base --pidfile /var/run/$base.pid" > else > name_param="--pidfile $pidfile" > fi > > The if clause checks for nonempty $pidfile instead of nonempty $base to > decide whether --name is used. > > Also --pidfile $pidfile is always used, even when $pidfile is empty. > > I am reportig this as serious since sid's start-stop-daemon requires a > name parameter in addition to --pidfile when the pidfile is not owned by > root, therefore this bug causes init script failures. (#921205) [ I am not familiar with src:lsb, but I need this issue resolved fixed to keep src:sysvinit suitable for Buster. By the way, sysvinit does not use killproc. ] I believe it would be reasonable to add '--name $base' into `else' clause. Opinions? PS. Dear maintainer, are you still willing to give-up maintainership of src:lsb ( comment in 888743)? -- Note, that I send and fetch email in batch, once every 24 hours. If matter is urgent, try https://t.me/kaction --