Control: tags -1 patch
On Tue, Mar 05, 2019 at 12:46:59PM +0200, Alberto Garcia wrote:
> > > If would also be nice if you can get a backtrace.
> >
> > Attached is a backtrace
>
> I forgot to clarify: I got this from the versions currently in
> unstable (epiphany 3.31.91-2, webkit 2.22.7-1).
>
> The MiniBrowser does run fine however, I can open e.g. Google Maps and
> use the website normally.
Ok, so this is a bug in Epiphany after all, I confirm that the
attached patch fixes the problem.
Here's the upstream merge request:
https://gitlab.gnome.org/GNOME/epiphany/merge_requests/218
Berto
diff --git a/embed/web-extension/ephy-web-extension.c b/embed/web-extension/ephy-web-extension.c
index 49335621262cae4c9c7ba97ee6ec1c33f223a471..9f6ab15ebe1e9a31263862b945339d295e3f721b 100644
--- a/embed/web-extension/ephy-web-extension.c
+++ b/embed/web-extension/ephy-web-extension.c
@@ -733,12 +733,10 @@ window_object_cleared_cb (WebKitScriptWorld *world,
js_ephy);
if (!extension->is_private_profile) {
- guint64 page_id = webkit_web_page_get_id (page);
- g_assert (page_id < G_MAXINT32);
-
g_autoptr(JSCValue) js_password_manager_ctor = jsc_value_object_get_property (js_ephy, "PasswordManager");
g_autoptr(JSCValue) js_password_manager = jsc_value_constructor_call (js_password_manager_ctor,
- G_TYPE_INT, page_id, G_TYPE_NONE);
+ G_TYPE_UINT64, webkit_web_page_get_id (page),
+ G_TYPE_NONE);
jsc_value_object_set_property (js_ephy, "passwordManager", js_password_manager);
js_function = jsc_value_new_function (js_context,
