Hi Joseph!
El mar., 1 de ene. de 2019 a la(s) 21:27, Joseph Herlant ( aerosti...@debian.org) escribió: > Control: tags -1 - fixed > Control: tags -1 + patch > Hi guys, > > Thanks Lucas for the report. Sorry for the late reply, I was out of > the country with very limited internet access. > > Thanks Emmanuel for the quick patch. > Notes for next time: > * Please use meaningful commit messages, especially when committing > to the master branch of a package you don't maintain. Using commit > messages like "fix issue 917717" makes the commit history harder to > read and the use of tools like gbp dch impossible as well as rendering > the gitlab hooks in place for tagging the bugs as pending unusable. > (If you're not sure about your patches, please just create a MR and > the maintainer can help getting the patch to a better standard) > Ok! I will do it!. What is the meaning of MR? * Please conform to the DEP-3 headers when you are writing a quilt > patch header. See https://dep-team.pages.debian.net/deps/dep3/ I used gbp-pq to create the patch. Maybe, I am using this tool from a wrong way? > * If you have a patch that you thing is good enough for Debian, it's > generally a good practice to propose it upstream as upstream is > generally aware of the potential negative impacts and this would avoid > having to maintain diverging patch hell, especially on packages you > don't maintain. > Ok. Thanks. > * Please don't tag bugs as "fixed" as long as there's no NMU uploaded > (as long as the package is not in the archive). In your case the tag > "patch" seems more appropriate. > Great. thanks > > There is an upstream upgrade I need to do so I'll clean the previous > points and do the upload today or tomorrow. > > Thanks, > Joseph > > _______________________________________________ > Python-modules-team mailing list > python-modules-t...@alioth-lists.debian.net > > https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team Thanks for your tips. I will keep them in mind :-) Cheers, -- Arias Emmanuel http://eamanu.com Github/Gitlab; @eamanu Debian: @eamanu-guest
