Control: tags -1 patch

On Mon, 20 Aug 2018 22:59:44 +0000 Santiago Vila <sanv...@debian.org> wrote:
> Package: src:libpodofo
> Version: 0.9.5-9
> Severity: serious
> Tags: ftbfs
> 
> Dear maintainer:
> 
> I tried to build this package in buster but it failed:

> [... snipped ...]

> cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/test/TokenizerTest && /usr/bin/cmake 
> -E copy_directory /<<PKGBUILDDIR>>/test/TokenizerTest/objects 
> /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/test/TokenizerTest/objects
> Error copying directory from "/<<PKGBUILDDIR>>/test/TokenizerTest/objects" to 
> "/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/test/TokenizerTest/objects".

As far as I can tell, there is no directory test/TokenizerTest/objects in the
source package, and trying to copy it is possibly a copy-paste error.
This did not cause an error prior to CMake 3.12, as documented in the release 
notes:

https://cmake.org/cmake/help/v3.12/release/3.12.html
"The cmake(1) -E copy_directory tool now fails when the source directory does 
not exist. Previously it succeeded by creating an empty destination directory."

My patch removes the directory copying command from the CMakeLists.txt.


Regards,
Juhani
Description: Before CMake 3.12, trying to copy a non-existing dir didn't fail
Author: Juhani Numminen <juhaninummin...@gmail.com>
Bug-Debian: https://bugs.debian.org/906781
Last-Update: 2018-08-27

--- a/test/TokenizerTest/CMakeLists.txt
+++ b/test/TokenizerTest/CMakeLists.txt
@@ -2,10 +2,3 @@
 TARGET_LINK_LIBRARIES(TokenizerTest ${PODOFO_LIB} ${PODOFO_LIB_DEPENDS})
 SET_TARGET_PROPERTIES(TokenizerTest PROPERTIES COMPILE_FLAGS "${PODOFO_CFLAGS}")
 ADD_DEPENDENCIES(TokenizerTest ${PODOFO_DEPEND_TARGET})
-
-# Copy the test samples over to the build tree
-ADD_CUSTOM_COMMAND(
-    TARGET TokenizerTest
-    POST_BUILD
-    COMMAND "${CMAKE_COMMAND}" -E copy_directory "${CMAKE_CURRENT_SOURCE_DIR}/objects" "${CMAKE_CURRENT_BINARY_DIR}/objects"
-    )

Reply via email to