Control: tags -1 patch
On Mon, Aug 06, 2018 at 02:25:35PM +0200, Niels Thykier wrote:
> Package: cppcheck
> Version: 1.84-1
> Severity: serious
>
> Hi,
>
> The cppcheck package FTBFS on arm*, ppc64el and s390x with following
> test failure:
>
> """
> test/testsymboldatabase.cpp:5076: Assertion failed.
> Expected:
> 1
>
> Actual:
> 0
>
> _____
> make[2]: *** [Makefile:248: test] Error 1
> make[2]: Leaving directory '/<<PKGBUILDDIR>>'
> """
>...
A patch is attached, but should be double-checked since I don't know
what this test is trying to check.
> Thanks,
> ~Niels
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
Description: Fix FTBFS on architectures where char is unsigned
Author: Adrian Bunk <[email protected]>
Bug-Debian: https://bugs.debian.org/905577
--- cppcheck-1.84.orig/test/testsymboldatabase.cpp
+++ cppcheck-1.84/test/testsymboldatabase.cpp
@@ -5038,7 +5038,7 @@ private:
" enum E1 { e1 };\n"
" enum class E2 : unsigned short { e2 };\n"
" bool get(bool x) { return x; }\n"
- " char get(char x) { return x; }\n"
+ " signed char get(signed char x) { return x; }\n"
" short get(short x) { return x; }\n"
" int get(int x) { return x; }\n"
" long get(long x) { return x; }\n"
