Le 28 juin 2018, Santiago Vila a écrit:

[...]

> There is an interesting line saying "unable to auto-detect email address"
> where it may be seen that my machine has no domain. However, having a
> domain has never been a requirement to build Debian packages.

This can probably easily be fixed by giving git an email. Could you test
the attached patch ? It should fix the problem, but I have no easily
available host with no domain to test it today.

> In fact, one might ask: The fact that such test fails means the
> package will not work in machines not having a domain?

magit use git, and for some operation, git ask for an email (for author
and committer identification). If it does not know one, it will
guess. For a user on any machine this can easily be fixed by running

  git config --global user.email m...@example.com

diff --git a/debian/changelog b/debian/changelog
index bb933827..9bcda3b2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+magit (2.13.0-2) unstable; urgency=medium
+
+  * Run test: set GIT_COMMITTER_EMAIL and GIT_AUTHOR_EMAIL to let test run
+    even if machine has no domain (Closes: #902640),
+    thanks to Santiago Vila <sanv...@debian.org>
+
+ -- Rémi Vanicat <vani...@debian.org>  Fri, 29 Jun 2018 08:50:29 +0200
+
 magit (2.13.0-1) unstable; urgency=medium
 
   * New upstream version
diff --git a/debian/rules b/debian/rules
index b23af1fe..3860bdf0 100755
--- a/debian/rules
+++ b/debian/rules
@@ -6,6 +6,8 @@ export DEB_VERSION_UPSTREAM
 # This is needed for running correctly the test in auto-builder
 export GIT_AUTHOR_NAME = "Magit testeur"
 export GIT_COMMITTER_NAME = "Magit committer"
+export GIT_AUTHOR_EMAIL = "magit-test...@example.org"
+export GIT_COMMITTER_EMAIL = "magit-test...@example.org"
 export LC_ALL = C.UTF-8
 
 %:
-- 
Rémi Vanicat

Reply via email to