Control: tags -1 patch
On Wed, Jan 10, 2018 at 10:57:29AM +0100, Emilio Pozuelo Monfort wrote:
> Source: qtcreator
> Version: 4.5.0-1
> Severity: serious
>
> Hi,
>
> qtcreator fails to build on armhf, as it can't find the file for the -O1 hack:
>
> # Hack over a g++ problem while using -O2 on armhf.
> # If you don't like this horrible hack please feel free to help me try to
> # reproduce it in a minimal test case so as to be able to properly fill a
> # bug against g++.
> sed -i 's/O2/O1/g' builddir/src/plugins/qmldesigner/Makefile.qmldesignerplugin
> sed: can't read builddir/src/plugins/qmldesigner/Makefile.qmldesignerplugin:
> No such file or directory
> debian/rules:32: recipe for target 'override_dh_auto_configure' failed
>
> Note that this was added quite a while back:
>
> qtcreator (3.1.2+dfsg-2) unstable; urgency=medium
> [...]
> [ Lisandro Damián Nicanor Pérez Meyer ]
> * Add a horrible hack in debian/rules for building a few files with -O1
> instead of -O2 on armhf. If you don't like this please be sure to help
> me to get a minimal test case in order to fill a proper bug against g++.
>
> -- Lisandro Damián Nicanor Pérez Meyer <lisan...@debian.org> Sun, 03 Aug
> 2014 13:36:05 -0300
>
> Maybe this is no longer needed due to the new qtcreator and/or new
> compiler versions?
Yes, I've confirmed that the following builds on armhf:
--- debian/rules.old 2018-01-24 21:52:37.599841492 +0000
+++ debian/rules 2018-01-24 21:52:53.244684450 +0000
@@ -44,14 +44,6 @@
CONFIG+=disable_external_rpath \
$(CURDIR) IDE_LIBRARY_BASENAME=lib/$(DEB_HOST_MULTIARCH)
IDE_PACKAGE_MODE=1 USE_SYSTEM_BOTAN=1 $(extra_configure_opts)
-ifeq ($(DEB_HOST_ARCH),$(findstring $(DEB_HOST_ARCH), armhf))
- # Hack over a g++ problem while using -O2 on armhf.
- # If you don't like this horrible hack please feel free to help me try
to
- # reproduce it in a minimal test case so as to be able to properly fill
a
- # bug against g++.
- sed -i 's/O2/O1/g'
builddir/src/plugins/qmldesigner/Makefile.qmldesignerplugin
-endif
-
override_dh_auto_install:
ifneq (,$(filter qtcreator-doc, $(shell dh_listpackages)))
dh_auto_build -- qch_docs
> Cheers,
> Emilio
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
