Control: tags -1 patch
On Tue, 31 Jan 2017 09:33:05 +0000 Matthias Klose <d...@debian.org> wrote:
> pam_chroot.c:873:18: error: '*' in boolean context, suggest '&&' instead
> [-Werror=int-in-bool-context]
> if(opts.flags * _PAM_OPTS_DEBUG) {
That is most likely a typo since everywhere else in the file it is
opts.flags & _PAM_OPTS_DEBUG (bitwise-AND &, not multiplication *).
Patch attached; tested on amd64 and i386 cowbuilder chroots.
Juhani
diff -u libpam-chroot-0.9/pam_chroot.c libpam-chroot-0.9/pam_chroot.c
--- libpam-chroot-0.9/pam_chroot.c
+++ libpam-chroot-0.9/pam_chroot.c
@@ -870,7 +870,7 @@
break;
default:
- if(opts.flags * _PAM_OPTS_DEBUG) {
+ if(opts.flags & _PAM_OPTS_DEBUG) {
_pam_log(LOG_NOTICE, "%s: returning failure", opts.module);
}
err = PAM_SESSION_ERR;
