On Fri, Nov 03, 2017 at 02:52:11PM -0700, Diane Trout wrote: > I restored it with git-revert and rebuilt 1.4.1 and 1.5 and discovered > there were #MISSING# symbols in each rebuild
That's at most to be expected, there was a SONAME bump in the meantime.
> 1.2 -> 1.4.1 had missing symbols but there was a package name &
> soversion bump from libhts1 to libhts2
Exactly.
> There was also symbols removed between 1.4.1 to 1.5 but upstream didn't
> change their SOVERSION.
This is one of the real problem. So if those symbols that were removed
were actually supposed to be part of a private API and not exported, and
nobody were supposed to try to reach them, then perahps they might be
marked as optional. But it needs to be evaluated accurately on a
symbol-by-symbols basis.
Personally, from the very quick look I had at them the other day, they
didn't look like some "private API".
> As an aside while I was looking at the missing symbols I found mfprintf
> was still listed in htslib 1.5's cram/mFILE.h, but the implementation
> had been removed from cram/mFILE.c
mh what the..
> Should we be patching the SOVERSION?
> File a bug upstream to have them update SOVERSION?
Depending on the kind of upstream, I'd either try to reach out to them
and see what are their plan for the next release where they could bump
the version, or rename the binary package to get things rebuilt
appropriately (unless we decide to declare those symbols as optional…).
Diane: thank you for dealing with this bug.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
