Control: found -1 146-1
Control: forwarded -1 https://github.com/cockpit-project/cockpit/pull/7397
Hello Chris,
Chris Lamb [2017-07-27 21:11 +0100]:
> I just ACCEPTed cockpit from NEW but noticed it was missing
> attribution in debian/copyright for at least Nokia in mock-io-stream.c.
Thanks for spotting!
> (This is not exhaustive so please check over the entire package
> carefully and address these on your next upload.)
I went over the source again with a reasonably fine comb:
git grep -i copyright | grep -Ev 'COPYING:|Red Hat'
and spotted mock-io-stream.c and a few others. PR sent (see above).
> I see there is some script to generate debian/copyright; perhaps it needs
> to be re-run, I'm not sure.. :)
That's only for the bundled JavaScript modules. It does get run with each
upstream PR and release, and as soon as an upstream PR changes the included
modules in a way that breaks automatic license detection it will fail CI, so
I'm reasonably sure on that part. But this doesn't cover the C code in src/.
Thanks,
Martin
