James Clarke <jrt...@debian.org> writes:

> Control: tags -1 patch
>
> These symbol files differences have been fixed by Ubuntu. I came to an
> identical patch independently before being told about it. I have also
> performed some additional cleanup where things are clearly based on
> bitness or endianness, which are *not* included in the Ubuntu delta, but
> I think should be in Debian for everyone's sanity.

Thanks!.

>
> Now for a slight rant: Please stop blindly applying patches to symbols
> files without thinking about what's going on. There were many instances
> of:

I agree that I should not blindly apply the patches. But since I clearly
do not understand the symbol files I rely on pkg-kde-tools symbolhelper
written by Russ.
>
>> arch=!amd64 !arm64 !armel !armhf !hppa !hurd-i386 !kfreebsd-amd64 
>> !kfreebsd-i386 !m68k !mips !mips64el !mipsel !powerpc !powerpcspe !ppc64 
>> !ppc64el !s390x !x32
>
> with the same symbol disappearing on alpha, sh4 and sparc64, causing the
> build to fail. Additionally, the symbol also disappeared on i386, but
> binary uploads to unstable were used. These must have been done in an
> outdated chroot. Source-only uploads are highly recommended to avoid
> things like this, but if you *are* going to do binary uploads, *please
> ensure your chroot is up to date*.

I've uploaded with updated chroot!. Anyway going forward I will adapt
source only upload to avoid these issues.

>
> Similarly, there were instances of:
>
>> arch=amd64 arm64 armel armhf hppa hurd-i386 kfreebsd-amd64 kfreebsd-i386 
>> m68k mips mips64el mipsel powerpc powerpcspe ppc64 ppc64el s390x x32
>
> with the symbol appearing on i386.
>
> I have checked the build (no symbol diff, even warnings) on amd64 and
> i386. I will continue to test other architectures and update this bug
> later today.

Thanks for this. Its already NMUed so I will have a look at patch and
acknowledge NMU.

Reply via email to