Your message dated Mon, 13 Feb 2017 09:48:29 +0000 with message-id <e1cddff-000cju...@fasolo.debian.org> and subject line Bug#852380: fixed in ekeyd 1.1.5-6.2 has caused the Debian Bug report #852380, regarding ekeyd: Does not start after luasocket upgrade to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 852380: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=852380 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: ekeyd Version: 1.1.5-6.1 Severity: grave Tags: patch Justification: renders package unusable After the recent upgrade of the lua-socket package to version 3.0~rc1+git+ac3201d-2, ekeyd no longer starts if Unix domain sockets are used (for either the control or EGD socket). Instead, it exits with this error message: Unable to run configuration file: control.lua:755: control.lua:526: attempt to index global 'socket' (a nil value) This is due to an incompatible change in the lua-socket API for Unix domain sockets. I have attached a patch which allows ekeyd to work with both the old and new versions of lua-socket, as well as an upcoming change that has not yet been packaged in Debian. (Git commit 3a33c37b; https://github.com/diegonehab/luasocket/commit/3a33c37b9ce852d0b3531e82c6ffdb47bb937f0a.) -- System Information: Debian Release: 9.0 APT prefers testing APT policy: (990, 'testing'), (700, 'unstable'), (500, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 4.8.0-1-amd64 (SMP w/8 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages ekeyd depends on: ii libc6 2.24-8 ii liblua5.1-0 5.1.5-8.1+b2 ii lua-socket 3.0~rc1+git+ac3201d-2 ii lua5.1 5.1.5-8.1+b2 Versions of packages ekeyd recommends: ii udev 232-8 Versions of packages ekeyd suggests: pn munin-node <none> -- Configuration Files: /etc/entropykey/ekeyd.conf changed [not included] /etc/entropykey/keyring [Errno 13] Permission denied: '/etc/entropykey/keyring' -- no debconf informationFrom: Courtney Bane <debian-bugs-4...@cbane.org> Date: Mon, 23 Jan 2017 20:30:59 -0600 Subject: Fix compatibility problems with Unix domain sockets in newer versions of luasocket. --- host/control.lua | 14 ++++++++------ host/ekeydctl.in | 7 ++++--- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/host/control.lua b/host/control.lua index 7b9b1b8..22d700f 100644 --- a/host/control.lua +++ b/host/control.lua @@ -38,11 +38,11 @@ local PROTOCOL_VERSION = "1" local dos_callcount = 0 -- Libraries we need -require "socket" +socket = require "socket" local have_unix_domain_sockets = false function tryload_unix() - require "socket.unix" + socket.unix = require "socket.unix" have_unix_domain_sockets = true end @@ -521,14 +521,15 @@ end if have_unix_domain_sockets then function UnixControlSocket(sockname) + local sock = socket.unix.stream or socket.unix.tcp or socket.unix -- Add a UDS control socket to the set of control sockets available -- First, try and connect, so we can abort if it's present. - if socket.unix():connect(sockname) then + if sock():connect(sockname) then error("Control socket " .. sockname .. " already present. Is ekeyd already running?") end -- Okay, clean up (ignoring errors) and create a fresh socket unlink(sockname) - local u = socket.unix() + local u = sock() assert(u:bind(sockname)) assert(u:listen()) addctlsocket(u, "U:" .. sockname) @@ -554,12 +555,13 @@ end _ "TCPControlSocket" if have_unix_domain_sockets then function EGDUnixSocket(sockname, modestr, user, group) SetFoldedOutput() - if socket.unix():connect(sockname) then + local sock = socket.unix.stream or socket.unix.tcp or socket.unix + if sock():connect(sockname) then error("EGD socket " .. sockname .. " already present. Is ekeyd/EGD already running?") end -- Add a UDS control socket to the set of control sockets available unlink(sockname) - local u = socket.unix() + local u = sock() assert(u:bind(sockname)) assert(u:listen()) addctlsocket(u, "U:" .. sockname, false, egd_ctlread) diff --git a/host/ekeydctl.in b/host/ekeydctl.in index 9292ac6..802cf38 100755 --- a/host/ekeydctl.in +++ b/host/ekeydctl.in @@ -1,11 +1,11 @@ #!/usr/bin/env lua@LUA_V@ -- -*- Lua -*- -require "socket" +local socket = require "socket" -- Try to load the UNIX domain sockets support pcall(function() - require "socket.unix" + socket.unix = require "socket.unix" end) @@ -98,7 +98,8 @@ end function connect_to_daemon() if __unixcontrolpath then - __socket = socket.unix() + local sock = socket.unix.stream or socket.unix.tcp or socket.unix + __socket = sock() local result, msg = __socket:connect(__unixcontrolpath) if not result then error("Unable to connect to ekeyd at " .. __unixcontrolpath .. " (" .. msg .. ") Is ekeyd running?")
--- End Message ---
--- Begin Message ---Source: ekeyd Source-Version: 1.1.5-6.2 We believe that the bug you reported is fixed in the latest version of ekeyd, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 852...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Simon McVittie <s...@debian.org> (supplier of updated ekeyd package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Sat, 04 Feb 2017 15:42:08 +0000 Source: ekeyd Binary: ekeyd ekeyd-egd-linux Architecture: source Version: 1.1.5-6.2 Distribution: unstable Urgency: medium Maintainer: Simtec Electronics <supp...@simtec.co.uk> Changed-By: Simon McVittie <s...@debian.org> Description: ekeyd - Simtec Electronics UDEKEY01 Entropy Key Daemon ekeyd-egd-linux - Transfers entropy from an EGD to the Linux kernel pool Closes: 852380 Changes: ekeyd (1.1.5-6.2) unstable; urgency=medium . * Non-maintainer upload. * Be compatible with newer versions of lua-socket (Closes: #852380). Based on patches from Mathieu Parent and Courtney Bane. * d/control: Make both binary packages depend on lsb-base for /lib/lsb/init-functions, as detected by Lintian Checksums-Sha1: a0b6ce65153381685012ec7471a1b80bd32b1b1d 1964 ekeyd_1.1.5-6.2.dsc 2c7c086198deb8fc7d255dc0bf35595dce35be95 9028 ekeyd_1.1.5-6.2.debian.tar.xz 605e13ef9a4c47dd081391bfe8012ac57f7f4ea6 4366 ekeyd_1.1.5-6.2_source.buildinfo Checksums-Sha256: 66579f32190a99061718d4332426bc2f7971d52e9c594ef4c85f72409da55c69 1964 ekeyd_1.1.5-6.2.dsc 2eba591c0388ae435f52094a02ef4abf02839f174291e29fbc9d33ab4d7cfaba 9028 ekeyd_1.1.5-6.2.debian.tar.xz 377ed4391e4a4a6f071d12ed4fb826c72ee8da62cbe1d092cf088863ce25557e 4366 ekeyd_1.1.5-6.2_source.buildinfo Files: b56fe51e79fd8829bdcf5f9fb6709998 1964 utils optional ekeyd_1.1.5-6.2.dsc 3b039da7aab4b49d0d3d5c4d2e0e44d9 9028 utils optional ekeyd_1.1.5-6.2.debian.tar.xz f98c0d72056abfb02c560223db72daf6 4366 utils optional ekeyd_1.1.5-6.2_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE2pjyXAhxxJpZ6v8sTej/KmPHzJAFAlia3pMACgkQTej/KmPH zJC9VA/+PXd/+OWmd0Ds3mFexn20zZeDtUFs7bL+kV/8lRiG2Ok0iKvMtZkRmoqS Vw8MZvSn3qwqJNVKAVvcNp12Th6o3jq7R1DuOpBdC14dCIHXhw6j40/m0BkGHFly CSCUzwiF2iR4kXztDXqtm2wZLAm/FZVaI4Z1cj6wxg2QVr5X8JHTF/qFD/6FwO9n ihcXvpYyaHi25ogNtgv5Q30wC9hSgkpuGAen/8WhNPVu7gSDi0yRhYUPGyCtsity Bs/yxLdpI+E3sQWB1j+nwbs3vzI8y2T+WjW67/ESL4Qnpgb7pp4Zp/VoF+JqIaG4 wkKWGTS2rVs9saeyUXLkGUkuM8haB5P4eS4YrBTHrS7UGwaxHvy8TrNIKLbVV3dp oFku2vGJ7T5h0e1kGKJqekGbl+KhaURaDDy6OHEgx7sdWl6i/tiTZQWMsBgK3NLt vk59HNkQsLlFjE9N5+q+P4o2TvujQXzenVL4G+WT6V3o/m18WiXLCps5YSFNX/r0 4qeVxamxBlmDS7fRfMj0J7iE0rwzAjwiuvqn9NpGfGf2vuNdG439QIS9gBVwrdhG Xi83bBwoWuc58BIxA1jFrNrElrkcA3Ne0fRXlQ3zJCyq0r2zKWxEtc7YjiXyRblj ssO5nmr16ypIiIfQBddW7nEvMoJ9XyK1DvuWXQIt9Non96s+v6g= =UGb8 -----END PGP SIGNATURE-----
--- End Message ---
