Hi,

I've noticed the patch to be able to import Pyro4 again when using Python 2.7 
without
having the selectors34 backport installed.
The patch however is not correct: it only sort of kinda fixes the import 
statement, but
not the code using it.  Importing 'select' as 'selectors' also makes no sense 
as these
modules contain different things. Finally, the actual code in 
multiplexserver.py depends
on various things that only the selectors module itself provides:
selectors.DefaultSelector and some constants such as selectors.EVENT_READ

With the patch as it is you will only be able to use Pyro4 in client code but 
as soon as
you create a server of type 'multiplexed' you'll run into trouble. This can be 
easily
seen by trying to start the built-in echo server (which runs as a multiplexed 
server
rather than a threaded one):

$ python -m Pyro4.test.echoserver

It will crash with AttributeError: 'module' object has no attribute 
'DefaultSelector'


I'm not sure what the best course of action is here, but I strongly suggest to 
re-open
the bug for now and not have the patch as it is right now.


Irmen de Jong
(Pyro4)

Reply via email to