On Wed, 11 Jan 2017 23:17:47 +0100 Christian Hofstaedtler wrote: > * Francesco Poli <invernom...@paranoici.org> [170111 22:51]: [...] > > the apcupsd.service file seems to lack any check for the > > ISCONFIGURED variable in /etc/default/apcupsd (unlike apcupsd.init, > > which aborts whenever that variable is not set to "yes"). > > > > Is this intentional? > > I think that the check should be implemented somehow... > > It's intentional for the test packages. I did not want to spend time > on implementing that if the proposed change doesn't work in the > first place.
Sounds reasonable... > > Suggestions on the actual implementation also welcome ;-) I am no systemd expert, but, after reading a bit of the systemd.service(5) man page, I would think about adding another ExecStartPre= (before the already existing one) and using it to run a script that fails in case ISCONFIGURED is not "yes"... But of course, I am not sure that making the "service apcupsd restart" command fail during the configuration of a newly installed apcupsd package is a good idea... Oh well, I need advice from people more knowledgeable than me! > (TBH, if I did this package anew today, I'd probably just install > with the service disabled/masked and not do the ISCONFIGURED dance, > but it's not a new package and it's not my package...) I can understand your point of view... I hope a NMU can be done soon (provided that Daniel's feedback is positive) to fix this RC bug. Thanks a lot for your time and dedication! Bye. -- http://www.inventati.org/frx/ There's not a second to spare! To the laboratory! ..................................................... Francesco Poli . GnuPG key fpr == CA01 1147 9CD2 EFDF FB82 3925 3E1C 27E1 1F69 BFFE
pgpof7lrpMgF1.pgp
Description: PGP signature
