control: reassign -1 src:resiprocate On 2016-12-19 21:57:42 [+0100], Daniel Pocock wrote:
> Thanks for taking the time to look at this. > > Is there an example of how this cleanup should be done, or is there a > specific line of code there that you believe is out of place? SSL_COMP_free_compression_methods() cleans libssl's memory. That is okay. But that piece I quoted is problematic: It grabs libssl internal pointer via SSL_COMP_get_compression_methods() and then calls free on it while the pointer remains in libssl for later. This is bad it should not do so. Invoking SSL_COMP_free_compression_methods() twice would not hurt _but_ must not be done in parallel (like from two threads). Better yet, switch to openssl 1.1.0 then none of those things have to be done because openssl uses the pthread thread model and takes care of this :) > If it is definitely not an openssl issue then the bug can be moved back > to src:resiprocate Done. > Regards, > > Daniel Sebastian
