On 12/09/16 20:51, Gianfranco Costamagna wrote:
Gianfranco, as per Policy ยง4.4, please put your own name in the
changelog trailer when making an upload.
well, it seems unfair wrt Peter,
IMO what the changelog should look like in a case like this is
imapcopy (1.04-2.1) unstable; urgency=medium
* Non-maintainer upload
[Peter Michael Green]
* Fix build with fpc 3.0.0 (Closes: 818448)
-- Gianfranco Costamagna<locutusofb...@debian.org> <date of upload>
This way it correctly identifies both who authored the change and who decided
it was ready to upload to Unstable.
You should only upload with someone else's name in the chagelog trailer if they
have explicitly asked for sponsorship.
who actually did *all* the work
<--snip-->
BTW on top of the changes, me and a friend of mine, tested the basic
functions of the imapcopy tool.
(not sure if the testing was complete or not, since it was just a FTBFS
fix and it was somewhere trivial).
the fix was referring network operations, it might break somewhere in some
particular
networks, but I think this isn't the case.
Maybe i'm overcautious but I will only NMU if I have tested at least the
basic functioning of the application and ideally have tested it in a way
that I know will hit the codepath I changed.
Figuring out how to test a given application, preparing a suitable test
environment etc is often more work than writing the actual patch. That
is why in this case I merely subimitted a patch to the bug report and
did not upload as a NMU myself.
IMO your actions testing that the fix was indeed ready for upload are as
valuable as my figuring out what needed to be changed to make the
package build.
