JFTR I took your patch and did a direct upload to sid to finally fix
these two RC bugs.

Also Ludovic, could you please take more care next time you sponsor an
upload? Unplanned transitions and FTBFS on r-deps are not something we
are very happy about.

Cheers,
-- 
Ondřej Surý <ond...@sury.org>
Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server
Knot Resolver (https://www.knot-resolver.cz/) – secure, privacy-aware,
fast DNS(SEC) resolver
Vše pro chleba (https://vseprochleba.cz) – Potřeby pro pečení chleba
všeho druhu

On Tue, Jun 28, 2016, at 14:59, Gianfranco Costamagna wrote:
> Hi
> 
> > since there has been no activity since initial reports, I am uploading
> > NMU to DELAYED/2 to fix the most critical bugs that makes the various
> > packages fail to build.
> 
> this debdiff looks wrong to me. I uploaded it in Ubuntu, and abiword
> failed to rebuild
> with the following message
> [snip]
> checking for tidy/tidy.h... no
> configure: error: MHT plugin: error - libtidy headers not found
>       "tail -v -n +0 config.log"
> 
> 
> of course, because with your changes the file is installed in
> usr/include/tidy.h
> 
> this looks wrong to me, specially because:
> 
> grep include . -R |grep '"'
> ./platform.h:#include "tidyplatform.h"
> ./buffio.h:#include "tidybuffio.h"
> ./tidybuffio.h:#include "tidyplatform.h"
> ./tidybuffio.h:#include "tidy.h"
> ./tidy.h:#include "tidyplatform.h"
> ./tidy.h:#include "tidyenum.h"
> ./tidyplatform.h:#include "dmalloc.h"
> 
> 
> they should be put in the same directory.
> 
> Moreover seems that we are missing a dmalloc.h library (dependency of the
> -dev package)
> 
> so I came with this patch, on top of your one
> 
> diff -Nru tidy-html5-5.2.0/debian/changelog
> tidy-html5-5.2.0/debian/changelog
> --- tidy-html5-5.2.0/debian/changelog   2016-06-28 10:22:09.000000000
> +0000
> +++ tidy-html5-5.2.0/debian/changelog   2016-06-28 12:47:46.000000000
> +0000
> @@ -1,3 +1,11 @@
> +tidy-html5 (1:5.2.0-1.1~build2) yakkety; urgency=medium
> +
> +  * Fix install location of header files.
> +  * Add libdmalloc-dev dependency for libtidy-dev, needed
> +    for dmalloc.h include
> +
> + -- Gianfranco Costamagna <locutusofb...@debian.org>  Tue, 28 Jun 2016
> 14:46:59 +0200
> +
>  tidy-html5 (1:5.2.0-1.1~build1) yakkety; urgency=medium
>  
>    * Upload to yakkety
> diff -Nru tidy-html5-5.2.0/debian/control tidy-html5-5.2.0/debian/control
> --- tidy-html5-5.2.0/debian/control     2016-06-28 10:20:42.000000000
> +0000
> +++ tidy-html5-5.2.0/debian/control     2016-06-28 12:46:57.000000000
> +0000
> @@ -47,7 +47,7 @@
>  Package: libtidy-dev
>  Section: libdevel
>  Architecture: any
> -Depends: libtidy5 (= ${binary:Version}), ${misc:Depends},
> ${shlibs:Depends}
> +Depends: libtidy5 (= ${binary:Version}), ${misc:Depends},
> ${shlibs:Depends}, libdmalloc-dev
>  Breaks: libtidy-0.99-0
>  Replaces: libtidy-0.99-0 
>  Description: HTML syntax checker and reformatter - development
> diff -Nru tidy-html5-5.2.0/debian/libtidy-dev.install
> tidy-html5-5.2.0/debian/libtidy-dev.install
> --- tidy-html5-5.2.0/debian/libtidy-dev.install 2016-06-28
> 10:20:42.000000000 +0000
> +++ tidy-html5-5.2.0/debian/libtidy-dev.install 2016-06-28
> 12:45:02.000000000 +0000
> @@ -1,6 +1,4 @@
>  README/RELEASE.html /usr/share/doc/libtidy-dev/
> -usr/include/tidy*
> -usr/include/buffio.h /usr/include/tidy/
> -usr/include/platform.h /usr/include/tidy/
> +usr/include/* /usr/include/tidy/
>  usr/lib/libtidy.so
>  usr/lib/libtidys.a
> 
> 
> Can you please cancel and consider reuploading with my patch?
> I'm not sure patching abiword is the correct solution, what do you think?
> 
> Gianfranco
> 
> Email had 1 attachment:
> + signature.asc
>   1k (application/pgp-signature)

Reply via email to