Package: petitboot
Version: 13.05.29.14.00-g4dc604b-1
Severity: serious
Tags: patch
Justification: fails to build from source
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu yakkety ubuntu-patch
Dear Maintainer,
petitboot currently fails to build from source on ppc64el due to outdated
libtool files. I had to grab a patch from upstream to fix a build problem
when invoking autoreconf, but now it builds properly on ppc64el in Ubuntu.
In Ubuntu, the attached patch was applied to achieve the following:
* Build with dh-autoreconf to fix FTBFS on ppc64el.
* debian/patches/fix-automake-warnings.patch: Grab patch from upstream Git
to fix warnings/errors during autoreconf.
Thanks for considering the patch.
Logan Rosen
-- System Information:
Debian Release: stretch/sid
APT prefers xenial-updates
APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500,
'xenial'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.4.0-21-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL
set to en_US.utf8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru petitboot-13.05.29.14.00-g4dc604b/debian/control petitboot-13.05.29.14.00-g4dc604b/debian/control
--- petitboot-13.05.29.14.00-g4dc604b/debian/control 2013-05-28 19:53:29.000000000 -0400
+++ petitboot-13.05.29.14.00-g4dc604b/debian/control 2016-06-24 20:39:12.000000000 -0400
@@ -9,7 +9,8 @@
libtinfo-dev,
libtwin-dev,
libudev-dev,
- pkg-config
+ pkg-config,
+ dh-autoreconf
Standards-Version: 3.9.4
Homepage: https://www.kernel.org/pub/linux/kernel/people/geoff/petitboot/petitboot.html
Vcs-Git: git://git.kernel.org/pub/scm/linux/kernel/git/geoff/petitboot.git
diff -Nru petitboot-13.05.29.14.00-g4dc604b/debian/patches/fix-automake-warnings.patch petitboot-13.05.29.14.00-g4dc604b/debian/patches/fix-automake-warnings.patch
--- petitboot-13.05.29.14.00-g4dc604b/debian/patches/fix-automake-warnings.patch 1969-12-31 19:00:00.000000000 -0500
+++ petitboot-13.05.29.14.00-g4dc604b/debian/patches/fix-automake-warnings.patch 2016-06-24 15:57:32.000000000 -0400
@@ -0,0 +1,75 @@
+From 434a6c9c100bc8daca1e6c41137f993d88f20fe3 Mon Sep 17 00:00:00 2001
+From: Geoff Levand <ge...@infradead.org>
+Date: Sun, 30 Jun 2013 13:45:58 -0700
+Subject: discover: Fix automake warnings
+
+Change the Makfile.am relocatable output files from automake _LIBRARIES
+to automake _PROGRAMS. Also, change the output file name extension
+from .o to .ro to better show these are relocatable files.
+
+Fixes automake warnings like these:
+
+ discover/Makefile.am: `libparser.o' is not a standard library name
+ discover/Makefile.am: did you mean `libparser.a'?
+
+Signed-off-by: Geoff Levand <ge...@infradead.org>
+---
+ discover/Makefile.am | 8 ++++----
+ test/parser/Makefile.am | 9 ++++-----
+ 2 files changed, 8 insertions(+), 9 deletions(-)
+
+--- a/discover/Makefile.am
++++ b/discover/Makefile.am
+@@ -19,9 +19,9 @@
+ -DPKG_SHARE_DIR='"$(pkgdatadir)"' \
+ -DLOCAL_STATE_DIR='"$(localstatedir)"'
+
+-noinst_LIBRARIES = libparser.o
++noinst_PROGRAMS = libparser.ro
+
+-libparser_o_SOURCES = \
++libparser_ro_SOURCES = \
+ parser.c \
+ parser.h \
+ parser-conf.c \
+@@ -35,7 +35,7 @@
+ yaboot-parser.c \
+ pxe-parser.c
+
+-libparser.o: $(libparser_o_OBJECTS)
++libparser.ro: $(libparser_ro_OBJECTS)
+ $(LD) -r -o $@ $^
+
+ EXTRA_DIST = native-parser.c
+@@ -63,7 +63,7 @@
+ user-event.c \
+ user-event.h
+
+-pb_discover_LDADD = libparser.o $(top_builddir)/lib/libpbcore.la
++pb_discover_LDADD = libparser.ro $(top_builddir)/lib/libpbcore.la
+
+ pb_discover_LDFLAGS = -ludev
+
+--- a/test/parser/Makefile.am
++++ b/test/parser/Makefile.am
+@@ -41,9 +41,9 @@
+ data/yaboot-rh8-ppc64.conf
+
+ common_libs = $(top_builddir)/lib/libpbcore.la
+-test_libs = libtest.o
++test_libs = libtest.ro
+
+-libtest.o: $(libtest_o_OBJECTS)
++libtest.ro: $(libtest_ro_OBJECTS)
+ $(LD) -o $@ -r $^
+
+ # objects under test
+@@ -58,7 +58,7 @@
+
+ LDADD = $(common_libs) $(test_libs)
+
+-libtest_o_SOURCES = utils.c parser-test.h handler.c main.c $(parser_test_objs)
++libtest_ro_SOURCES = utils.c parser-test.h handler.c main.c $(parser_test_objs)
+
+ $(check_PROGRAMS): %: %.embedded-config.o
+ $(check_PROGRAMS): LDADD += $@.embedded-config.o
diff -Nru petitboot-13.05.29.14.00-g4dc604b/debian/patches/series petitboot-13.05.29.14.00-g4dc604b/debian/patches/series
--- petitboot-13.05.29.14.00-g4dc604b/debian/patches/series 1969-12-31 19:00:00.000000000 -0500
+++ petitboot-13.05.29.14.00-g4dc604b/debian/patches/series 2016-06-24 16:40:30.000000000 -0400
@@ -0,0 +1 @@
+fix-automake-warnings.patch
diff -Nru petitboot-13.05.29.14.00-g4dc604b/debian/rules petitboot-13.05.29.14.00-g4dc604b/debian/rules
--- petitboot-13.05.29.14.00-g4dc604b/debian/rules 2012-02-15 18:16:23.000000000 -0500
+++ petitboot-13.05.29.14.00-g4dc604b/debian/rules 2016-06-24 16:28:16.000000000 -0400
@@ -18,7 +18,10 @@
%:
- dh $@
+ dh $@ --with autoreconf
override_dh_auto_configure:
dh_auto_configure -- --with-twin-x11=yes --with-twin-fbdev=yes
+
+override_dh_autoreconf:
+ dh_autoreconf ./bootstrap
