Source: lincity Version: 1.13.1-12 Severity: serious Justification: fails to build from source Tags: patch
Dear Maintainer,
This package failed to be built from source. Also, lincity cannot be
play on amd64. It crashed.
(gdb) run
Starting program: /tmp/d1/lincity-1.13.1/debian/lincity/usr/games/lincity
PNG Header: 1360 x 1600, bd=8, ct=3
Program received signal SIGSEGV, Segmentation fault.
0x0000000000419edd in load_png_graphic (type=0, group=0, id=0x453677
"green",
txt_fp=0x721510, row_pointers=0x72daf0, width=1360, height=1600)
at readpng.c:576
576 if (!fnp || *fnp == '#') continue;
(gdb) print fnp
$1 = 0xffffffffffffbc00 <error: Cannot access memory at address
0xffffffffffffbc00>
(gdb) print buf
$2 = "##\000size 1
buildings\n\000\000\000\000@\027r\000\000\000\000\000@\027r\000\000\000\000\000\000\023\275`\210\257\000\246@\027r\000\000\000\000\000\001\000\000\000\377\177\000\000\000\000\000\000\000\000\000\000\347\317f\367\000\000\000\000\060j\236\366\377\177\000\000\340\022r",
'\000' <repeats 13 times>,
"\020*@\000\000\000\000\000p\336\377\377\377\177\000\000\000\000\000\000\000\000\000"
(gdb)
This is basically because there are many implicit declaration of
function warnings and must be fixed.
I've attached a patch to fix this bug. Please review it.
Many Thanks,
Paul
-- System Information:
Debian Release: stretch/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.5.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored:
LC_ALL set to zh_TW.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages lincity depends on:
ii libc6 2.22-7
ii libice6 2:1.0.9-1+b1
ii libpng16-16 1.6.21-4
ii libsm6 2:1.2.2-1+b1
ii libx11-6 2:1.6.3-1
ii libxext6 2:1.3.3-1
ii zlib1g 1:1.2.8.dfsg-2+b1
lincity recommends no packages.
lincity suggests no packages.
-- no debconf information
--
PaulLiu (劉穎駿)
E-mail: Ying-Chun Liu (PaulLiu) <[email protected]>
Description: Fix implicit declaration of function warnings This patch fixes the FTBFS bug. Also fixes a crash bug on 64-bits systems. Author: Ying-Chun Liu (PaulLiu) <[email protected]> Last-Update: 2016-05-05 Index: lincity-1.13.1/main.c =================================================================== --- lincity-1.13.1.orig/main.c +++ lincity-1.13.1/main.c @@ -41,6 +41,10 @@ #include <lcx11.h> #endif +#if !defined(WIN32) +#include <locale.h> +#endif + #include "lctypes.h" #include "lin-city.h" #include "cliglobs.h" Index: lincity-1.13.1/readpng.c =================================================================== --- lincity-1.13.1.orig/readpng.c +++ lincity-1.13.1/readpng.c @@ -3,6 +3,7 @@ * This file is part of lincity (see COPYRIGHT for copyright information). * ---------------------------------------------------------------------- */ #include <stdlib.h> +#include <string.h> #include "png.h" #include "malloc.h" #include "lin-city.h"
signature.asc
Description: OpenPGP digital signature
