Control: tags -1 + patch

Hi,

On Wed, Jul 08, 2015 at 05:14:42PM +0200, Andreas Beckmann wrote:
> Package: abook
> Version: 0.6.0~pre2-4
> Severity: serious
> User: debian...@lists.debian.org
> Usertags: piuparts
> 
> Hi,
> 
> during a test with piuparts I noticed your package failed to install. As
> per definition of the release team this makes the package too buggy for
> a release, thus the severity.
> 
> >>From the attached log (scroll to the bottom...):
> 
>   Selecting previously unselected package abook.
>   (Reading database ... 
> (Reading database ... 7475 files and directories currently installed.)
>   Preparing to unpack .../abook_0.6.0~pre2-4_amd64.deb ...
>   Unpacking abook (0.6.0~pre2-4) ...
>   Setting up abook (0.6.0~pre2-4) ...
>   /var/lib/dpkg/info/abook.postinst: 58: /var/lib/dpkg/info/abook.postinst: 
> update-menus: not found
>   dpkg: error processing package abook (--configure):
>    subprocess installed post-installation script returned error exit status 
> 127
>   Errors were encountered while processing:
>    abook

The problem lies in the postinst. It changed away from testing for the
hardcoded pathname /usr/bin/update-menus to 

which update-menus

but the argument to -x is not quoted. A simple patch is:

----cut---------cut---------cut---------cut---------cut---------cut-----
diff -Nru abook-0.6.0~pre2/debian/postinst abook-0.6.0~pre2/debian/postinst
--- abook-0.6.0~pre2/debian/postinst    2015-07-06 17:35:05.000000000 +0200
+++ abook-0.6.0~pre2/debian/postinst    2015-07-08 18:52:55.000000000 +0200
@@ -54,6 +54,6 @@
 
 
 # menu entry
-if [ "$action" = 'configure' ] && [ -x `which update-menus` ]; then
+if [ "$action" = 'configure' ] && [ -x "`which update-menus`" ]; then
        update-menus 
 fi
----cut---------cut---------cut---------cut---------cut---------cut-----


Otherwise switching to a debhelper based packaging using
dh_installmenu, will replace the right snippet in the postinst as
well.

Regards,
Salvatore


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to