Control: tag -1 wontfix help Hello Bastien,
bastien ROUCARIÈS [2015-05-31 22:12 +0000]: > According to Debian Free Software Guidelines [1] (DFSG) #2: > "The program must include source code, and must allow distribution > in source code as well as compiled form.". > > This could also constitute a license violation for some copyleft licenses > such > as the GNU GPL. date.js is under MIT license, not under GPL, and MIT does not require shipping the "preferred form of modification". So this is *not* a license violation. > In order to solve this problem, you could: > 1. repack the origin tarball adding the missing source to it. > 2 add the source files to "debian/missing-sources" directory > > Both way satisfies the requirement that we ship the source. Second option > might be preferable due to the following reasons [2]: > - Upstream can do it too and you could even supply a patch to them, thus > full > filling our social contract [3], see particularly §2. > - If source and non-source are in different locations, ftpmasters may > miss the source and (needlessly) reject the package. > - The source isn't duplicated in every .diff.gz/.debian.tar.* (though > this only really matters for larger sources). I think all this speaks for option 1, and that's what I'd do if there actually was source code for date.js. The original copyright holder www.coolite.com is long gone, together with the original upstream site http://www.datejs.com/, and indeed https://code.google.com/p/datejs/downloads/list is the only remaining place where to download date.js. But the "date.js" file there is the minified version as well; Datejs-all-Alpha1.zip contains the individual files from which date.js was built, but again all the build tools like sugarpak.js and also parts of the library like time.js are just minified. So merely including that zip file into calibre's orig.tar.gz wouldn't help much as (1) it's still not enough to (re)build date.js from completely unminified sources, and (2) it would greatly increase the number of shipped minified sources, thus aggravating this bug. TBH this would be a rather useless academic exercise. Minified .js is certainly a bit awkward, but with some automatic tools for reformatting source code it's in no way impossible to modify it. Thus I'm not going to change anything from my side. I don't have the time/motivation to hunt down the old copyright holders, ask them for "proper" source code, and I heavily disagree that this is a serious bug as there is no license violation. If someone wants to do this work, please go ahead. If Debian's QA team wants to continue considering this a serious bug, I won't veto and just keep calibre in unstable then. Thanks, Martin -- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
signature.asc
Description: Digital signature
