Your message dated Sun, 25 Jan 2015 09:19:05 +0000
with message-id <e1yfjlv-0006dh...@franck.debian.org>
and subject line Bug#775313: fixed in debsums 2.0.52+nmu3
has caused the Debian Bug report #775313,
regarding debsums -c don't report all changed files
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
775313: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=775313
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: debsums
Version: 2.0.52+deb7u1
Severity: serious
Tags: patch
Justification: required

Hi,
  I'd like to notice, than the patch [2.0.52+nmu2 from Axel Beckert, see: 
https://launchpadlibrarian.net/176696862/debsums_2.0.52%2Bnmu1_2.0.52%2Bnmu2.diff.gz]
creates this issue:
when there are two (or more) files (starting with the same string in the path), 
so the changes of the shorter files are not reported
by debsums -c ... .

In my case for example:
# dpkg-query "--admindir=/var/lib/dpkg" -S "bin/ls"
util-linux: /bin/lsblk
syslinux-common: /usr/bin/lss16toppm
kmod: /bin/lsmod
e2fsprogs: /usr/bin/lsattr
lsb-release: /usr/bin/lsb_release
pciutils: /usr/bin/lspci
lsof: /usr/bin/lsof
usbutils: /usr/bin/lsusb
gnupg: /usr/bin/lspgpot
klibc-utils: /usr/lib/klibc/bin/ls
coreutils: /bin/ls
util-linux: /usr/bin/lscpu
initramfs-tools: /usr/bin/lsinitramfs
kmod: /sbin/lsmod

# dpkg-query "--admindir=/var/lib/dpkg" -S "bin/ls"| awk -F: '{print $1}'
util-linux
syslinux-common
kmod
e2fsprogs
lsb-release
pciutils
lsof
usbutils
gnupg
klibc-utils
coreutils
util-linux
initramfs-tools
kmod


So then $correct_package = 
"util-linux\nsyslinux-common\nkmod\ne2fsprogs\nlsb-release\npciutils\nlsof\nusbutils\ngnupg\nklibc-utils\ncoreutils\nutil-linux\ninitramfs-tools\nkmod"

These files are silently skipped by the check:
if ($pack ne $correct_package) {
    # print "$pack != $correct_package\n";
    return 0;
}

The starting slash of the '-S' argument can repare the main bug (this will not 
use pattern *usr/sbin/inchange-reporting* is used):
# dpkg-query "--admindir=/var/lib/dpkg" -S "/bin/ls"| awk -F: '{print $1}'
coreutils

For example, change of /bin/ls will report nothing in wheeze, ..., unstable 
will not report anything:
# cp -a /bin/ls /tmp/ls ; echo "bad addon" >> /bin/ls; debsums -c coreutils; cp 
-a /tmp/ls  /bin/ls

Since patched version report it:
# cp -a /bin/ls /tmp/ls ; echo "bad addon" >> /bin/ls; debsums.new -c 
coreutils; cp -a /tmp/ls  /bin/ls
/bin/ls

Please aply this patch to fix this issue:
# diff -Nu /usr/bin/debsums /usr/bin/debsums.new 
--- /usr/bin/debsums    2014-09-01 20:47:24.000000000 +0200
+++ /usr/bin/debsums.new    2015-01-13 08:20:17.000000000 +0100
@@ -462,7 +462,7 @@
        return 0;
    }
 
-   my $correct_package = `dpkg-query "--admindir=$DPKG" -S "$path" | awk -F: 
'{print \$1}'`;
+   my $correct_package = `dpkg-query "--admindir=$DPKG" -S "/$path" | awk -F: 
'{print \$1}'`;
    chomp($correct_package);
    if ($pack ne $correct_package) {
        #print "$pack != $correct_package\n";

Please fix it in wheeze, ...

With regards
-- Marek Veber


-- System Information:
Debian Release: 7.8
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-4-686-pae (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages debsums depends on:
ii  dpkg                  8:1.16.9+nmu1
ii  libdpkg-perl          8:1.16.9+nmu1
ii  libfile-fnmatch-perl  0.02-1+b2
ii  perl                  5.14.2-21+deb7u2
ii  ucf                   8:3.0025+nmu4.1

debsums recommends no packages.

debsums suggests no packages.

-- debconf information excluded
--- /usr/bin/debsums	2015-01-13 15:26:23.000000000 +0100
+++ /usr/bin/debsums.new	2015-01-13 08:20:17.000000000 +0100
@@ -462,7 +462,7 @@
 	    return 0;
 	}
 
-	my $correct_package = `dpkg-query "--admindir=$DPKG" -S "$path" | awk -F: '{print \$1}'`;
+	my $correct_package = `dpkg-query "--admindir=$DPKG" -S "/$path" | awk -F: '{print \$1}'`;
 	chomp($correct_package);
 	if ($pack ne $correct_package) {
 	    #print "$pack != $correct_package\n";

--- End Message ---
--- Begin Message ---
Source: debsums
Source-Version: 2.0.52+nmu3

We believe that the bug you reported is fixed in the latest version of
debsums, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 775...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Axel Beckert <a...@debian.org> (supplier of updated debsums package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 14 Jan 2015 22:55:45 +0100
Source: debsums
Binary: debsums
Architecture: source all
Version: 2.0.52+nmu3
Distribution: unstable
Urgency: medium
Maintainer: Ryan Niebur <r...@debian.org>
Changed-By: Axel Beckert <a...@debian.org>
Description:
 debsums    - tool for verification of installed package files against MD5 chec
Closes: 775313
Changes:
 debsums (2.0.52+nmu3) unstable; urgency=medium
 .
   * Non-maintainer upload
   * Fix case where previous patch doesn't report all changed files.
     (Closes: #775313) Thanks Marek Veber for report and patch!
Checksums-Sha1:
 0ce5ed0eeb6af8c7a38fcbaac2a1975c218393d7 1587 debsums_2.0.52+nmu3.dsc
 07bbc729b216de9fc6edb8b5cdb180fc7cb24c6d 46444 debsums_2.0.52+nmu3.tar.xz
 c25ba18c54bded6119f4e2d70b9e760aec060948 47868 debsums_2.0.52+nmu3_all.deb
Checksums-Sha256:
 6a6b4e7a805419c61bcc943c8cb9ed9f36a969b25cdd464c7bd3a200f8265e61 1587 
debsums_2.0.52+nmu3.dsc
 e1163e97456de95a1964d407dd7f94c60117d975e7b1c50fbf8b24059ac9aad1 46444 
debsums_2.0.52+nmu3.tar.xz
 bfdc32c019110ca163fb7ffc72c4e386ad4cde4f752395525b790623fcc60737 47868 
debsums_2.0.52+nmu3_all.deb
Files:
 853b9f9fc0125d67882b7da4c68c8d4e 1587 admin optional debsums_2.0.52+nmu3.dsc
 bb21b21f24ac298b18a98f0fcf3b7474 46444 admin optional 
debsums_2.0.52+nmu3.tar.xz
 481aac769b1de028ca857e6ac0a7696b 47868 admin optional 
debsums_2.0.52+nmu3_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJUxKP2AAoJEIy+IZx0V22B7UoQAMkSRRdrZfV+nKnbXRe/3TAg
Y+eRy+XK2yPvhAOPofkYvTY33Y8AF5NUKvAOSyDtDteowYVVT2BCvAtP4P7z48Ik
ptzktep1N9jLcy/v5HAl5tYNhzsGQXyK/PMa7Xyn8KfD1mKHwHtDvf56vDNHeM7a
UAf3tYG3d/ZbzL1DZot24UtY6DqONYv2FJGKkbJft3ul3rkm8j5mjL37N+Rb6DIX
kTlG+Mj8gbXGD0oMFET99ezpYr8fEGNfD4JOOSrGJMELEeuDrn1De1yrcxy7pHRE
6C1sTBcRonaRlhHPW3wKYVrY8Bi+azvmvQ57djwACKXvE+cGh556uvdsxP3yerqA
iZp7H09UduPNKcUYvsT+sehQeIe8VxN/d+whzSi2Ta6OvBZlsVOXKGchzZa4l/p/
DtllSsIcTFDk5CWpE3Qqx+IxORM08Cfd6+VzkBBt4BoRysTXIPaTDFdNuZYrrWDh
sPl/Hs2IeqwP1TYWzsuyW6s8syv9fytL/bkC43wFSp4T+3WPczElQm1wxDbyDceE
6T1nKnpdWzlilhPajjCKAYGi4zY5E9rCobkh6j2UXwQasBglbaNkZnVQI0tCqhDV
d36CBgqHGeoPtBDdXTsFdvesx2b0uF+RrDaU5vonK2tReXJFvjJyUEqEIPsdCodu
kYS9VCdDF8CCbobZXAS1
=BUin
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to