Your message dated Wed, 26 Nov 2014 09:06:04 +0800
with message-id <[email protected]>
and subject line Re: [PKG-Openstack-devel] Bug#770941: closed by Thomas Goirand
<[email protected]> (Re: Bug#770941: nova-common - Overrides database config in
nova.conf)
has caused the Debian Bug report #770941,
regarding nova-common - Overrides database config in nova.conf
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
770941: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770941
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: nova-common
Version: 2014.1.3-6
Severity: serious
A simple upgrade or re-install of nova-common overrides the database
settings in nova.conf:
| diff -ur nova/nova.conf /etc/nova/nova.conf
| --- nova/nova.conf 2014-10-02 15:09:04.672855761 +0200
| +++ /etc/nova/nova.conf 2014-11-25 12:02:37.194997496 +0100
| @@ -349,7 +349,7 @@
| # DATABASE #
| ############
| [database]
| -connection = postgresql:///nova
| +connection = postgresql://novacommon:XXXXXXXXX@localhost/novadb
|
|
| #############
This violates ยง10.7.3 of the Debian policy: local changes must be
preserved.
Bastian
-- System Information:
Debian Release: jessie/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'testing-updates'), (500, 'unstable'),
(500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- End Message ---
--- Begin Message ---
On 11/25/2014 10:15 PM, Bastian Blank wrote:
> Control: reopen -1
>
> On Tue, Nov 25, 2014 at 02:03:06PM +0000, Debian Bug Tracking System wrote:
>> However, unless I'm mistaking, the above "connection =
>> postgresql:///nova" is *not* a valide DSN, so it's not surprising that
>> it got replaced. I don't consider this a bug, especially that there's
>> all the logic in place to read an actual valid configuration.
>
> It is a valid DSN.
In this:
postgresql:///nova
Where's the user and password? What's the hostname?
If theoretically, this *may* be a valid DSN, but practically, I don't
think you'd be using a DNS without a valid hostname, login and pass.
> And even if not, it must not change it.
The idea behind the policy is that a config script shouldn't change a
valid configuration, so that it is possible edit the configuration file,
and that change be kept when installing or upgrading.
If you write something reasonable as your DSN (eg: with a hostname,
login and password), the maintainer scripts will keep that working
configuration as expected, and as per the policy. So it is my view that
there's no issue here.
Running a nova installation without any kind of auth in your db is out
of the scope of this package. If you wish to do so, then I would accept
a patch to openstack-pkg-tools to support what you want, but I would
find weird to spend even a few minutes on this.
Cheers,
Thomas Goirand (zigo)
P.S: Please don't reopen the bug. The config and postinst scripts are
doing exactly what I wanted them to do, and I feel like this is the
correct behavior. If you don't like the current behavior, I welcome you
to discuss it in the packaging list, but using BTS ping-pong isn't the
way to do so.
--- End Message ---
