Your message dated Sun, 02 Nov 2014 15:50:52 +0000
with message-id <[email protected]>
and subject line Bug#764130: fixed in libdbi 0.9.0-4
has caused the Debian Bug report #764130,
regarding libdbi1: double-free in dbi_shutdown_r
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
764130: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764130
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libdbi1
Version: 0.9.0-3
Severity: serious
Tags: upstream
Hi,
I'm seeing a double-free in dbi_shutdown_r which happens after a
connection attempt (using dbi_conn_connect) fails and dbi_conn_close was
called. I don't have a full reproduction case yet but I think this is
related to the fix for #745980. I *assume* that the following happens:
- dbi_conn_open adds the new connection to an internal list (using
_update_internal_conn_list)
- dbi_conn_connect does not touch that list
- when calling dbi_conn_close after connect failed (supposedly
conn->connection == NULL), the connection is not removed since
dbi_conn_close returns early but after freeing the connection object
(_update_internal_conn_list would only happen when not returning
early)
- when calling dbi_shutdown_r, the connection is still in the internal
list and another attempt to close the connection is done causing an
invalid read and the double-free
I think the right fix is to not return early at all in dbi_conn_close
but instead guard each single operation by checking if the required
fields are set (similar to how it's done in most cases already).
Let me know if you need any other information -- I can then try to come
up with a small test-case which reproduces the problem.
TIA,
Sebastian
--
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/
Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Source: libdbi
Source-Version: 0.9.0-4
We believe that the bug you reported is fixed in the latest version of
libdbi, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Laszlo Boszormenyi (GCS) <[email protected]> (supplier of updated libdbi package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 01 Nov 2014 12:06:55 +0000
Source: libdbi
Binary: libdbi1 libdbi-dev libdbi-doc libdbi1-dbg
Architecture: source amd64 all
Version: 0.9.0-4
Distribution: unstable
Urgency: medium
Maintainer: Laszlo Boszormenyi (GCS) <[email protected]>
Changed-By: Laszlo Boszormenyi (GCS) <[email protected]>
Description:
libdbi-dev - DB Independent Abstraction Layer for C -- development files
libdbi-doc - DB Independent Abstraction Layer for C -- documentation
libdbi1 - DB Independent Abstraction Layer for C -- shared library
libdbi1-dbg - DB Independent Abstraction Layer for C -- debugging symbols
Closes: 764130
Changes:
libdbi (0.9.0-4) unstable; urgency=medium
.
* Backport fix for double-free in dbi_shutdown_r() (closes: #764130).
* Update Standards-Version to 3.9.6 .
Checksums-Sha1:
9f1161184d3fbe43b74836e5ab7c818eb5227438 2062 libdbi_0.9.0-4.dsc
80d09f3cd73956033a310536dbc0dd2fea8d2f95 7336 libdbi_0.9.0-4.debian.tar.xz
7b226d6a3e92006bd820d2ad844ed6e297d88a34 32342 libdbi1_0.9.0-4_amd64.deb
7facc98fe5b9ed5b705bb70632b234a9aa097f9e 34754 libdbi-dev_0.9.0-4_amd64.deb
d54d2803a844d0ebf8f1cf3bb9e9e7b9e100a3e9 753692 libdbi-doc_0.9.0-4_all.deb
8431e4072be07ac517cf7815a18f1ad71cbca2b1 55236 libdbi1-dbg_0.9.0-4_amd64.deb
Checksums-Sha256:
588691b31245268d01ce64a1089b06fe965b4f0a481954a841ee2d175734940b 2062
libdbi_0.9.0-4.dsc
c79fed777fa87f9038418732511d5e0465ffd23f03e31bc76df8f0a95712339e 7336
libdbi_0.9.0-4.debian.tar.xz
a528b6795d8859f55148311f85cd225bde119a7c4d60e5241e208909a46a4f85 32342
libdbi1_0.9.0-4_amd64.deb
52d69af8633b8644b4463015bc3c2e465fcf04ac23487b36475cee628a6fda03 34754
libdbi-dev_0.9.0-4_amd64.deb
d8d39a7b343f41f51d1ef2e90ce426b1b96f567350cffebfeb4962d6d30a78c1 753692
libdbi-doc_0.9.0-4_all.deb
e576ce820109b2802733cc22502c2325267daa9f2f272f77e0843bd7ab65926c 55236
libdbi1-dbg_0.9.0-4_amd64.deb
Files:
3b26e9dfc5d0964b67904810ee0c8c47 2062 libs optional libdbi_0.9.0-4.dsc
167f2ccc4333f07205c9e37542762eb1 7336 libs optional
libdbi_0.9.0-4.debian.tar.xz
f95adc051380a65da657908ffc8a03be 32342 libs optional libdbi1_0.9.0-4_amd64.deb
2b46b67a29b0a845dcbe24782426376c 34754 libdevel optional
libdbi-dev_0.9.0-4_amd64.deb
3a2216523b38a34cc97fc776b8e2c572 753692 doc optional libdbi-doc_0.9.0-4_all.deb
e95d38d98d45ab2ade116f8cdfdc8b51 55236 debug extra
libdbi1-dbg_0.9.0-4_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJUVZuKAAoJENzjEOeGTMi/awEP/3wNEGkppzJJry4/iW+oOAok
y+24vWhokdHZ6mztlmr9j5AIs8t8q9uR++8KFalyHqgSDPG0ODWm4GWg/nWbruHm
ntljjLJhEn1SwhIbCikXSvUy1t43auKvpeHzMt6SVIHxYcwSe26rQImh3TWJ/WY9
F6mwe8kiT9y3qlH7fOjclEpspHDlLRqPYn9pZ89UyeEVUNaRjSoH8+vi09+key27
GTfUSaFMbxcwfspIVe/siUhuisxyleX8xQ7kUOJnfQeX85DBjwPvQ8DMnYJFdWvp
EmParoYGNea/J5FPX961aLFOosHn7QUWNh4YnnJAoiP25OYXw+Fzu7DlLiE21UOH
6q3LtXkBB6AkflltbRM/rRCACcuscWt/UEaPQWKcXJ2t6YdRo7r94TtTBVxrjtxI
4zF097nFdAJjReDluNh/BaKnoxmFUiug2Wy6xTMKDEzWCKHy06Ythk/2mzNFKXbh
pNZWYKV6J7PEY+vRkhBTy90f9VUhnOdJR/idkZbedAGKvkGkcegR5ZBfYR6ZJp98
07mdaRlWX5v5Sb9AoR7/a2M1O3ZoRs90Eq9WRYq3qgsSI0q8plW9/xNDsgF+Ap6h
9QKTuzRNMeCElqzfomoSQhrG+5D0x9dKhXE95ThSbgsI6P8jAeMfIaoyBiLDhrBZ
jD5tqMuhchY+d2AcBuQm
=jSax
-----END PGP SIGNATURE-----
--- End Message ---
