Hi, On Tue, 06 May 2014, Bastien ROUCARIES wrote: > I have uploaded a new version on mentors with modification asked by raphael.
I just noticed that the gitpkg workflow has been defined by you Bastien, and not by Frank. Please consider using the traditional git-buildpackage workflow instead. Having a README.source with so many instructions is not a good way to make it easy to maintain the package. Does the Debian JS team recommend a workflow? On Mon, 12 May 2014, Bastien ROUCARIES wrote: > Do you agree with my changes ? I need a ack for your part in order to > get it sponsored. > > BTW do you agree to push ckeditor to be team maintained by debian js > team (I could do this change also). Frank agreed with someone else taking the package over so I guess it's OK to move it to the Debian JS team. Since the removal deadline is today, I uploaded your package but here are some comments on your package: * debian/patches/0001-Removed-autogenerated-code.patch: Please consider using DEP-3 to document the patch (http://dep.debian.net/deps/dep3/) in particular a link to ticket where you forwarded the patch would have been nice * debian/source/options: drop that file, xz is the default already and "compression-level=9" is counter-productive (requires lots of memory and is much slower, the default value has been chosen as the best compromise) * debian/README.source, see my former comment about the workflow * debian/rules: it would be cleaner to build ckeditor.js in override_dh_auto_build instead... that's something that should be done without root rights before the install step. Cheers, -- Raphaël Hertzog ◈ Debian Developer Discover the Debian Administrator's Handbook: → http://debian-handbook.info/get/ -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
