Hi Andreas, Le jeudi, 2 janvier 2014, 18.49:31 Andreas Barth a écrit : > > … and this new proposal was more than six months ago: > I opposed having an upload of > "rmdir -rf /var/run/mgetty || true"
Sure; I read that. That said, gregoa's patch is significantly different
from that, as it does the following:
> - don't create the directories in mgetty-fax.dirs
--- mgetty-1.1.36/debian/mgetty-fax.dirs
+++ mgetty-1.1.36/debian/mgetty-fax.dirs
@@ -9,3 +9 @@
-var/lock/fax
var/log/mgetty/fax
-var/run/mgetty-fax
> - don't change their permissions in mgetty-fax.postinst
> - they are already created at runtime in mgetty-fax.init.d
> including setting permissions
--- mgetty-1.1.36/debian/mgetty-fax.postinst
+++ mgetty-1.1.36/debian/mgetty-fax.postinst
@@ -54,8 +54,7 @@
dpkg-statoverride --update --add $FAX_USER $FAX_GROUP 4755
/usr/lib/mgetty-fax/faxq-helper;
fi
- for i in /var/spool/fax/outgoing /var/log/mgetty/fax \
- /var/run/mgetty-fax /var/lock/fax; do
+ for i in /var/spool/fax/outgoing /var/log/mgetty/fax; do
if ! dpkg-statoverride --list $i >/dev/null; then
dpkg-statoverride --update --add $FAX_USER root 0755 $i;
fi
and
> - remove them in mgetty-fax.postrm during purge
--- mgetty-1.1.36/debian/mgetty-fax.postrm
+++ mgetty-1.1.36/debian/mgetty-fax.postrm
@@ -17,6 +17,7 @@
rmdir /etc/mgetty || true;
rm -f /var/spool/fax/outgoing/faxqueue_done
rmdir /var/spool/fax/outgoing /var/spool/fax || true;
+ rm -rf /var/lock/fax /var/run/mgetty-fax
;;
*)
;;
> I think that is still legitimite to not want to have that done.
Sure; I didn't challenge that.
> > Le mercredi, 21 août 2013, 15.41:53 gregor herrmann a écrit :
> > I will therefore upload a new 1.1.36-1.7 with the fixes for both
> > #719501 and #689899 to DELAYED/5 (although devref §5.11.1 would
> > allow a direct upload).
>
> This is not correct. If you don't like my decisions, you need to have
> them overwritten by the tech ctte.
According to the buglog, you opposed "rmdir -rf /var/run/mgetty || true
or similar". gregoa proposed something different back in august 2013 to
which you didn't respond (or even apparently read). That was four months
ago (the bug itself is now 14 months old.
I'm proposing to upload this proposal which, in my reading, doesn't fit
what you opposed.
> So please remove your upload until I can review the situation again.
It hasn't been uploaded yet, as it was building on my slow server. But
unless you oppose the patch _content_ (and not the belief that I would
upload a variation of rmdir -f) which I'm attaching to this mail for
your convenience, I will upload this NMU to DELAYED/5.
Cheers,
OdyXdiff -u mgetty-1.1.36/debian/changelog mgetty-1.1.36/debian/changelog
--- mgetty-1.1.36/debian/changelog
+++ mgetty-1.1.36/debian/changelog
@@ -1,3 +1,23 @@
+mgetty (1.1.36-1.7) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Include the two proposed patches from gregor herrmann, thank you!
+
+ [ gregor herrmann ]
+ * Fix "FTBFS with perl 5.18: POD errors":
+ apply patch from from brian m. carlson to debian/vm.pod.
+ (Closes: #719501)
+ * Fix "Ships a folder in /var/run or /var/lock (Policy Manual section
+ 9.3.2)":
+ - don't create the directories in mgetty-fax.dirs
+ - don't change their permissions in mgetty-fax.postinst
+ - they are already created at runtime in mgetty-fax.init.d
+ including setting permissions
+ - remove them in mgetty-fax.postrm during purge
+ (Closes: #689899)
+
+ -- Didier Raboud <o...@debian.org> Thu, 02 Jan 2014 18:20:26 +0100
+
mgetty (1.1.36-1.6) unstable; urgency=low
* Non-maintainer upload.
diff -u mgetty-1.1.36/debian/mgetty-fax.postinst mgetty-1.1.36/debian/mgetty-fax.postinst
--- mgetty-1.1.36/debian/mgetty-fax.postinst
+++ mgetty-1.1.36/debian/mgetty-fax.postinst
@@ -54,8 +54,7 @@
dpkg-statoverride --update --add $FAX_USER $FAX_GROUP 4755 /usr/lib/mgetty-fax/faxq-helper;
fi
- for i in /var/spool/fax/outgoing /var/log/mgetty/fax \
- /var/run/mgetty-fax /var/lock/fax; do
+ for i in /var/spool/fax/outgoing /var/log/mgetty/fax; do
if ! dpkg-statoverride --list $i >/dev/null; then
dpkg-statoverride --update --add $FAX_USER root 0755 $i;
fi
diff -u mgetty-1.1.36/debian/vm.pod mgetty-1.1.36/debian/vm.pod
--- mgetty-1.1.36/debian/vm.pod
+++ mgetty-1.1.36/debian/vm.pod
@@ -26,9 +26,12 @@
=item devicetest
+=back
=head1 OPTIONS
+=over 4
+
=item B<-c n>
use compression type B<n>
@@ -68,6 +71,8 @@
=item B<-V n>
set silence threshold to <n> (0-100%%)
+=back
+
=head1 SEE ALSO
L<vgetty(1)>
diff -u mgetty-1.1.36/debian/mgetty-fax.postrm mgetty-1.1.36/debian/mgetty-fax.postrm
--- mgetty-1.1.36/debian/mgetty-fax.postrm
+++ mgetty-1.1.36/debian/mgetty-fax.postrm
@@ -17,6 +17,7 @@
rmdir /etc/mgetty || true;
rm -f /var/spool/fax/outgoing/faxqueue_done
rmdir /var/spool/fax/outgoing /var/spool/fax || true;
+ rm -rf /var/lock/fax /var/run/mgetty-fax
;;
*)
;;
diff -u mgetty-1.1.36/debian/mgetty-fax.dirs mgetty-1.1.36/debian/mgetty-fax.dirs
--- mgetty-1.1.36/debian/mgetty-fax.dirs
+++ mgetty-1.1.36/debian/mgetty-fax.dirs
@@ -9,3 +9 @@
-var/lock/fax
var/log/mgetty/fax
-var/run/mgetty-fax
signature.asc
Description: This is a digitally signed message part.
