Control: tag -1 + confirmed patch

On Sun, 06 Oct 2013 21:52:15 +0200, David Suárez wrote:

> > dh_install -psquid3 --sourcedir=/«PKGBUILDDIR»/debian/tmp 
> > cp: cannot stat 
> > '/«PKGBUILDDIR»/debian/tmp/usr/share/man/man8/basic_db_auth.8': No such 
> > file or directory

The manpage is not there to be installed because it doesn't get
built.

From the ./configure run:

pod2man: unable to format
configure: Basic auth helper DB ... found but cannot be built

Reading configure shows that it tests with
helpers/basic_auth/DB/config.test:

## Test: do we have perl to build the helper scripts?
## Test: do we have pod2man to build the manual?
perl --version >/dev/null && echo | pod2man >/dev/null

and this fails (probably due to changes in Perl 5.18) with the error
quoted above.

Same for
    helpers/log_daemon/DB/config.test
and
    helpers/external_acl/SQL_session/config.test
.


I suggest to replace the weird test in the three config.test files
with something like

command -v perl >/dev/null && command -v pod2man >/dev/null


Comments?


Cheers,
gregor, attaching a debdiff

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Dire Straits: Six Blade Knife
diff -Nru squid3-3.3.8/debian/changelog squid3-3.3.8/debian/changelog
--- squid3-3.3.8/debian/changelog       2013-07-22 00:08:07.000000000 +0200
+++ squid3-3.3.8/debian/changelog       2013-10-25 23:10:06.000000000 +0200
@@ -1,3 +1,15 @@
+squid3 (3.3.8-1.1) UNRELEASED; urgency=low
+
+  * Non-maintainer upload.
+  * Fix "FTBFS: cp: cannot stat
+    '/«PKGBUILDDIR»/debian/tmp/usr/share/man/man8/basic_db_auth.8': No
+    such file or directory":
+    new patch 17-pod2man-check.patch:
+    fix config.test files' check for perl and pod2man
+    (Closes: #725599)
+
+ -- gregor herrmann <[email protected]>  Fri, 25 Oct 2013 21:22:24 +0200
+
 squid3 (3.3.8-1) unstable; urgency=high
 
   * Urgency high due to security fixes
diff -Nru squid3-3.3.8/debian/patches/17-pod2man-check.patch 
squid3-3.3.8/debian/patches/17-pod2man-check.patch
--- squid3-3.3.8/debian/patches/17-pod2man-check.patch  1970-01-01 
01:00:00.000000000 +0100
+++ squid3-3.3.8/debian/patches/17-pod2man-check.patch  2013-10-25 
23:18:18.000000000 +0200
@@ -0,0 +1,40 @@
+Description: fix check for perl and pod2man
+ At least under Perl 5.18, the current version fails with
+ | pod2man: unable to format
+ | configure: FOO ... found but cannot be built
+Origin: vendor
+Bug-Debian: http://bugs.debian.org/725599
+Forwarded: no
+Author: gregor herrmann <[email protected]>
+Last-Update: 2013-10-25
+
+--- a/helpers/basic_auth/DB/config.test
++++ b/helpers/basic_auth/DB/config.test
+@@ -2,6 +2,6 @@
+ 
+ ## Test: do we have perl to build the helper scripts?
+ ## Test: do we have pod2man to build the manual?
+-perl --version >/dev/null && echo | pod2man >/dev/null
++command -v perl >/dev/null && command -v pod2man >/dev/null
+ 
+ exit $?
+--- a/helpers/external_acl/SQL_session/config.test
++++ b/helpers/external_acl/SQL_session/config.test
+@@ -2,6 +2,6 @@
+ 
+ ## Test: do we have perl to build the helper scripts?
+ ## Test: do we have pod2man to build the manual?
+-perl --version >/dev/null && echo | pod2man >/dev/null
++command -v perl >/dev/null && command -v pod2man >/dev/null
+ 
+ exit $?
+--- a/helpers/log_daemon/DB/config.test
++++ b/helpers/log_daemon/DB/config.test
+@@ -2,6 +2,6 @@
+ 
+ ## Test: do we have perl to build the helper scripts?
+ ## Test: do we have pod2man to build the manual?
+-perl --version >/dev/null && echo | pod2man >/dev/null
++command -v perl >/dev/null && command -v pod2man >/dev/null
+ 
+ exit $?
diff -Nru squid3-3.3.8/debian/patches/series squid3-3.3.8/debian/patches/series
--- squid3-3.3.8/debian/patches/series  2013-07-22 00:07:44.000000000 +0200
+++ squid3-3.3.8/debian/patches/series  2013-10-25 23:07:04.000000000 +0200
@@ -2,3 +2,4 @@
 02-makefile-defaults.patch
 15-cachemgr-default-config.patch
 16-ipc-statedir.patch
+17-pod2man-check.patch

Attachment: signature.asc
Description: Digital signature

Reply via email to