On Sat, 01 Jun 2013 19:10:35 +0200, Benjamin Mesing wrote: > thanks for the NMU it looks ok to me, but I am not sure if it might not > break things for the future (I will deal with those with the next > upload, since I also intend to upload a new version of umlet). > Perhaps you can answer me some questions, with regards to the NMU? > > * "/usr/bin/umlet" looks like this: > ---begin--- > #!/bin/sh > > # Include the wrappers utility script > . /usr/lib/java-wrappers/java-wrappers.sh > > # We need java6 runtime > find_java_runtime java6 > > run_java -jar /usr/share/java/umlet.jar "$@" > ---end--- > Will this work with a java7 system only (i.e. once default-java > changed to java7)?
Looking at /usr/lib/java-wrappers/jvm-list.sh I see:
# The java* runtimes:
__jvm_java7="$__jvm_openjdk7"
# -> corresponds to Provides: java6-runtime
__jvm_java6="$__jvm_openjdk6 $__jvm_sun6 $__jvm_java7"
which looks like it should work.
> * What is the recommended way to find/use a java version with at
> least java6 compatibility? Lacking a proper way here was the
> main reason, why I hardcoded the openjdk6 dependency.
I guess the current shell wrapper does this already.
> * You did add the option: -o"-encoding utf8" to the jh_build
> command. Was this neccessary to make the package compile?
No, I just thought it's save and _might_ help for the future; but in
fact it's not really appropriate according to the letter of the NMU
guidelines, sorry.
> Btw. I see no reason to rush this bug,
Well, it's release critical, and the Java team is planning to switch
the default to openjdk-7 soon, so umlet is a blocker for this
transition right now.
> so I do not fully understand why
> you NMUed this without giving any information beforehand. It is usually
> a good idea to contact the maintainer first (and required by policy).
In my understanding uploading to a DELAYED queue and sending the diff
to the BTS is the canonical way of informing the maintainer.
> It
> is (was) on my agenda but might still take some time.
I'm still happy to cancel to NMU if you prefer to do the change
yourself.
Cheers,
gregor
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Ludwig Hirsch: Der Elefant
signature.asc
Description: Digital signature
