Your message dated Wed, 22 May 2013 12:02:56 +0000
with message-id <e1uf7ku-00026q...@franck.debian.org>
and subject line Bug#707793: fixed in smcroute 0.95-2
has caused the Debian Bug report #707793,
regarding smcroute: [PATCH] smcroute segfaults on vtun interfaces
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
707793: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=707793
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: smcroute
Version: 0.95-1
Severity: important
Tags: patch

Dear Maintainer,

   * What led up to the situation?
        I use smcroute to route over vtun interfaces. After upgrade from 
squeeze to wheezy, it segfaults when there are vtun interfaces active.
   * What exactly did you do (or not do) that was effective (or
     ineffective)?
        Patch smcroute to not deref a NULL-pointer. The first run, the 
ifa->ifa_addr is NULL, but it seems to call the function twice, and the second 
time the field is set, so in the end it works fine.
   * What was the outcome of this action?
        smcroute does not segfault anymore
   * What outcome did you expect instead?

Please find attached a patch to fix a NULL-pointer dereference. The manpage for 
struct ifaddr says explicitly that ifa_addr can be NULL, so that should be 
checked.


-- System Information:
Debian Release: 7.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=UTF-8 (charmap=locale: Cannot set LC_CTYPE 
to default locale: No such file or directory
locale: Cannot set LC_ALL to default locale: No such file or directory
ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages smcroute depends on:
ii  libc6  2.13-38

smcroute recommends no packages.

smcroute suggests no packages.

-- Configuration Files:
/etc/smcroute/startup.sh changed [not included]

-- debconf information excluded
--- ifvc.orig.c	2013-05-11 12:07:49.000000000 +0200
+++ ifvc.c	2013-05-11 12:06:51.000000000 +0200
@@ -50,7 +50,8 @@
   }
 
   for (ifa = ifaddr; ifa != NULL; ifa = ifa->ifa_next) {
-    int family = ifa->ifa_addr->sa_family;
+    int family = 0;
+    if(ifa->ifa_addr) family  = ifa->ifa_addr->sa_family;
 
     /* Skip non-IPv4 and non-IPv6 interfaces */
     if ((family != AF_INET) && (family != AF_INET6)) continue;

--- End Message ---
--- Begin Message ---
Source: smcroute
Source-Version: 0.95-2

We believe that the bug you reported is fixed in the latest version of
smcroute, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 707...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Micha Lenk <mi...@debian.org> (supplier of updated smcroute package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 22 May 2013 13:41:51 +0200
Source: smcroute
Binary: smcroute
Architecture: source amd64
Version: 0.95-2
Distribution: unstable
Urgency: low
Maintainer: Micha Lenk <mi...@debian.org>
Changed-By: Micha Lenk <mi...@debian.org>
Description: 
 smcroute   - static multicast router daemon
Closes: 707793
Changes: 
 smcroute (0.95-2) unstable; urgency=low
 .
   * Switch to dpkg-source 3.0 (quilt) format for easier patch maintenance.
   * Added patch 01_fix_segfault.patch to fix a NULL pointer dereferencing in
     interface vector initialization (closes: #707793, LP: #1043688).
Checksums-Sha1: 
 c739b30c35125b3e86a4c3506d839d0d8178e5db 1742 smcroute_0.95-2.dsc
 7b15a4c59006762b1b1f69e769417f5ecbbcd605 4702 smcroute_0.95-2.debian.tar.gz
 f047ec12dcb1b26483aee107a35d7db829e56ce3 23726 smcroute_0.95-2_amd64.deb
Checksums-Sha256: 
 9f2e775cffe1fb778636c79d629c9f0c49a0ea9f5afec7f50a6c20d978c354bb 1742 
smcroute_0.95-2.dsc
 273ea21604261f9a92c0792b19a52e074800ac0bbb4e2f910c38d5f0b7d4051a 4702 
smcroute_0.95-2.debian.tar.gz
 7b00e0057baebf74b6bcd08c3ac2811874145cd3699709daf25685512e46e5d0 23726 
smcroute_0.95-2_amd64.deb
Files: 
 163886f910a6e91a4d31e206577d7f54 1742 net extra smcroute_0.95-2.dsc
 f1ca2eb498c952eabd5f072ca30423a6 4702 net extra smcroute_0.95-2.debian.tar.gz
 2fb843f685150aa61c9b554a9505b273 23726 net extra smcroute_0.95-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJRnLEWAAoJEOpsprlRuFE5Y+AP/AkD4QROI91JO53wjyOS6yTU
P/EopBWrgzsd+J2vrbs9eVMOaQ0RmFlYlUy+FIzi4jwQhaKtXEhUHD36+bglCrFM
YBaa3d7sjlmmOtJDu7S1d4ZJ1fKAOgLTHIBjIeVzHP2vciMEvGEtT1pPgY/y2+NK
TiI+b7SHHTIz5yZm9DDid+Pkzkb4jRqFrTpIK4kRY3+0JGCZKnGV2JTfVNS8aGrk
DJwT9s/m3w//+QDgEY58EefMz+9dD56BR55NGZ0T+yJyU4u5obP7NKTOn8iDgN8c
/b/H4DjGqzQAxGBAgIHL39jLf4gBXMAGhbBWIuRVnO3R1QReMt86a6nltlEFZkut
SQErUL52bzht758kIdnWpbZ+aeEbmHIxDrFiUx5+KIWs6ut/REkFHCmofuMMB1YY
13CggJFeZmD5loOjIHXHckFrEKCsBpQUoysaA0Nb4fD6ouKeAM+23bZUTCSopezH
j4H5yaVY514tuE6ZOTwMj7Cjv59xyWeI3sUzUU3K1uKC4gkHxt8pmKrQ/N8e3MTh
zGxJBjC/eKzN9dgJ/8cOmWPjixwvbXDQvIvnFbnBT4XRpLa83MITYTZ/lF7aOHRl
3auqI8esamtxFZzomidnSrxNGb6A2LtY3o6vmRihR0SlhWD7znEqAqahbVuQ0mhu
vdOS3FzEOOVCV0G16xtn
=PrHj
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to